Nodes: Construct clip distances objects in NodeBuilder. #28915
+263
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📦 Bundle sizeFull ESM build, minified and gzipped.
🌳 Bundle size after tree-shakingMinimal build including a renderer, camera, empty scene, and dependencies.
|
c8afc20
to
afd146f
Compare
|
Is clip-distances available in current browsers. WGSL doesn't seem to recognize clip_distances as an extension in Chrome 127 or Firefox Nightly, and the clip_distances builtin is not recognized with or without the extension. This pull request seems to suggest that it's merged in, while the official W3 documentation includes it as an extendible functionality in vertex shaders. |
… no conditional extension support in GLSLNodeBuilder and clip_distances are no longer an enable feature as of Chrome 127, so we'll need to think of a way to support older systems that still need it enabled if that is what we want
961599c
to
b594315
Compare
| @@ -605,6 +606,51 @@ | |||
|
|
|||
| } | |||
|
|
|||
| enableClipDistanceIndex( index ) { | |||
|
|
|||
| const extensions = this.renderer.backend.extensions; | |||
Check notice
Code scanning / CodeQL
Unused variable, import, function or class Note
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #28578, #28615
Allow for the construction of hardware configurable clip distances object within each backend's NodeBuilder.
enableExtension()Method toGLSLNodeBuilder#28952