WebGPURenderer: Add Enable Directive/Enable-Extension Support #28615
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #28578
According to the WGSL specification, enable extensions are features required to utilize certain features like f16 floats and clip_distances. These extensions can be utilized within a shader if the shader calls its corresponding enable directive and the corresponding feature is enabled on the GPUDevice. There are a few upsides and downsides to providing WGSLNodeBuilder the ability to create shaders with enable directives.
Downsides:
Upsides:
Description
The implementation is effectively just a simplified version of WGSLNodeBuilders' builtins code. Directives were only added to vertex and compute shaders since they seem to be the only shader stages that currently have directives associated with them.