r34518 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r34517‎ | r34518 | r34519 >
Date:14:44, 9 May 2008
Author:catrope
Status:old
Tags:
Comment:
(bug 14021) Removing titles= support from list=backlinks, has been obsolete for ages (since July 2007)
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/api/ApiQueryBacklinks.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/api/ApiQueryBacklinks.php
@@ -260,20 +260,14 @@
261261 }
262262
263263 protected function processContinue() {
264 - $pageSet = $this->getPageSet();
265 - $count = $pageSet->getTitleCount();
266 -
267264 if (!is_null($this->params['continue']))
268265 $this->parseContinueParam();
269266 else {
270267 $title = $this->params['title'];
271268 if (!is_null($title)) {
272269 $this->rootTitle = Title :: newFromText($title);
273 - } else { // This case is obsolete. Will support this for a while
274 - if ($count !== 1)
275 - $this->dieUsage("The {$this->getModuleName()} query requires one title to start", 'bad_title_count');
276 - $this->rootTitle = current($pageSet->getTitles()); // only one title there
277 - $this->setWarning('Using titles parameter is obsolete for this list. Use ' . $this->encodeParamName('title') . ' instead.');
 270+ } else {
 271+ $this->dieUsageMsg(array('missingparam', "title"));
278272 }
279273 }
280274
Index: trunk/phase3/RELEASE-NOTES
@@ -326,6 +326,7 @@
327327 * (bug 14013) Added rcshow=patrolled to list=recentchanges
328328 * (bug 14028) Added language attribute to interwiki map in meta=siteinfo
329329 * (bug 14022) Added usprop=registration and auprop=blockinfo
 330+* (bug 14021) Removed titles= support from list=backlinks (has been obsolete for ages)
330331
331332 === Languages updated in 1.13 ===
332333

Follow-up revisions

RevisionCommit summaryAuthorDate
r34565* Re-applying r34449, r34500 and r34518 which Brion reverted by accident...catrope10:49, 10 May 2008

Status & tagging log