Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for PaymentResponse.retry() #11101

Merged
merged 9 commits into from
Aug 13, 2018
Merged

Add tests for PaymentResponse.retry() #11101

merged 9 commits into from
Aug 13, 2018

Conversation

marcoscaceres
Copy link
Contributor

@marcoscaceres marcoscaceres commented May 22, 2018 •
edited by wpt-pr-bot
Loading

@marcoscaceres marcoscaceres mentioned this pull request May 22, 2018
Closed
7 tasks
@marcoscaceres marcoscaceres mentioned this pull request Jun 7, 2018
Merged
7 tasks
@marcoscaceres
Copy link
Contributor Author

@mnoorenberghe, when possibly, would appreciate review of these tests - so I can land the first part of retry().

@marcoscaceres
Copy link
Contributor Author

@domenic, I added two manual (😿) tests for "fully active", based on PaymentRequest.show()'s tests...

  1. Immediate check .retry() being called on document that is not fully active.
  2. After .retry() is called, the then document becomes not fully active.

@marcoscaceres
Copy link
Contributor Author

Gentle ping, fellow reviewers 🍰

@marcoscaceres marcoscaceres mentioned this pull request Jul 3, 2018
Merged
5 tasks
@marcoscaceres marcoscaceres mentioned this pull request Jul 16, 2018
Merged
2 tasks
aarongable pushed a commit to chromium/chromium that referenced this pull request Aug 2, 2018
@romandev
PaymentRequest: Implement PaymentResponse.retry() in renderer and mojo
be463a2 
This patch only includs an implementation of PaymentResponse.retry() in
renderer and mojo side. We should implement UI in browser side in follow
up CLs.

Once this patch is applied, most test cases will be passed except when
the UI is required.

Intent to implement:
  https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/wayZGnuBkrI

Test:
  //components/payments/core/payments_validators_unittest.cc
  //third_party/blink/renderer/modules/payments/payments_validators_test.cc
  web-platform-tests/wpt#11101

Bug: 861704
Change-Id: I8a644a32ed589a2292ad021f5699105482ad9dd1
Reviewed-on: https://chromium-review.googlesource.com/1142045
Reviewed-by: Kinuko Yasuda <[email protected]>
Reviewed-by: Rouslan Solomakhin <[email protected]>
Commit-Queue: Jinho Bang <[email protected]>
Cr-Commit-Position: refs/heads/master@{#580126}
@marcoscaceres
Copy link
Contributor Author

@domenic, any chance you could review these? I'm struggling to find people to help me with reviewing tests 😢

@domenic
Copy link
Member

domenic commented Aug 10, 2018

Sorry, I don't have the bandwidth for this :(. Hopefully anyone who's planning to implement would be willing to review?

@marcoscaceres marcoscaceres requested review from rsolomakhin and removed request for domenic, mnoorenberghe and MSFTkihans August 10, 2018 23:09
@marcoscaceres
Copy link
Contributor Author

Np, maybe @rsolomakhin?

@wpt-pr-bot
Copy link
Collaborator

There are no reviewers for this pull request besides its author. Please reach out on W3C's irc server (irc.w3.org, port 6665) on channel #testing (web client) to get help with this. Thank you!

@marcoscaceres marcoscaceres merged commit 2f996e7 into master Aug 13, 2018
@sideshowbarker sideshowbarker deleted the payment_request_retry branch November 22, 2018 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rsolomakhin rsolomakhin rsolomakhin approved these changes

Assignees
No one assigned
Labels
payment-request status:needs-reviewers wg-payments
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@marcoscaceres @domenic @wpt-pr-bot @rsolomakhin