Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(protocol): remove unused code post Ontake fork #18072

Merged
merged 109 commits into from
Sep 20, 2024
Merged

refactor(protocol): remove unused code post Ontake fork #18072

merged 109 commits into from
Sep 20, 2024

Conversation

dantaik
Copy link
Contributor

@dantaik dantaik commented Sep 11, 2024 •
edited
Loading

Replacing #18014.

Note:

  • do not merge this PR until all pre-Ontake fork blocks have been verified.
  • this branch is read-only for audit; any additional changes shall merge to branch ontake_cleanup_followup

dantaik and others added 30 commits September 10, 2024 10:36
@dantaik dantaik added option.do-not-merge option.pinned Will not be marked as stale automatically labels Sep 12, 2024
@dantaik
Copy link
Contributor Author

dantaik commented Sep 12, 2024 •
edited
Loading

@davidtaikocha The deployment of the protocol on L1 workflow takes for ever on this branch, could you take a look: https://github.com/taikoxyz/taiko-mono/actions/runs/10824687402/job/30032348779?pr=18072. You can try to run the work flow locally, same failure.

Screenshot 2024-09-12 at 14 05 35

@davidtaikocha
Copy link
Member

@davidtaikocha The deployment of the protocol on L1 workflow takes for ever on this branch, could you take a look: https://github.com/taikoxyz/taiko-mono/actions/runs/10824687402/job/30032348779?pr=18072. You can try to run the work flow locally, same failure.

OK, trying

@davidtaikocha
Copy link
Member

@davidtaikocha The deployment of the protocol on L1 workflow takes for ever on this branch, could you take a look: https://github.com/taikoxyz/taiko-mono/actions/runs/10824687402/job/30032348779?pr=18072. You can try to run the work flow locally, same failure.

Screenshot 2024-09-12 at 14 05 35
image image Looks like no issue on my laptop....

@davidtaikocha davidtaikocha mentioned this pull request Sep 16, 2024
Closed
dantaik and others added 7 commits September 18, 2024 14:04
@dantaik
Merge branch 'main' into ontake_cleanup
127563c
@dantaik
Merge branch 'main' into ontake_cleanup
dab5675
@dantaik
remove genesis data file
074eecc
@dantaik
Merge branch 'main' into ontake_cleanup
cf08eaf
@dantaik
Merge branch 'main' into ontake_cleanup
0187ed7
@dantaik @bearni95
@taiko-kitty @RogerLamTd @mask-pp @smtmfft @YoGhurt111 @davidtaikocha @lagunovsky @cyberhorsey @kimo-ice
feat(protocol): features and fixes to be applied to the audited versi…
b427447 
…on (#18107)

Co-authored-by: Bernat Canal Garceran <[email protected]>
Co-authored-by: taiko-bot <[email protected]>
Co-authored-by: Roger <[email protected]>
Co-authored-by: maskpp <[email protected]>
Co-authored-by: smtmfft <[email protected]>
Co-authored-by: Gavin Yu <[email protected]>
Co-authored-by: David <[email protected]>
Co-authored-by: Ivan Lagunovsky <[email protected]>
Co-authored-by: jeff <[email protected]>
Co-authored-by: Karim <[email protected]>
Co-authored-by: Karim <[email protected]>
Co-authored-by: dantaik <[email protected]>
@dantaik
Merge branch 'main' into ontake_cleanup
343b3aa
@dantaik dantaik changed the base branch from main to ontake_cleanup2 September 20, 2024 02:07
@dantaik dantaik merged commit ce76e66 into ontake_cleanup2 Sep 20, 2024
5 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
area.protocol option.do-not-merge option.pinned Will not be marked as stale automatically
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dantaik @davidtaikocha