Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed MatterJS type definitions #6746

Merged
merged 3 commits into from
Sep 3, 2024
Merged

fixed MatterJS type definitions #6746

merged 3 commits into from
Sep 3, 2024

Conversation

lukas-dachtler
Copy link
Contributor

@lukas-dachtler lukas-dachtler commented Feb 25, 2024 •
edited
Loading

This PR fixes type definitions for MatterJS

Changes:

  • marked updateVelocity as optional parameter
  • included reference for phaser types
  • declared type for onCollideWith

@lukas-dachtler
Copy link
Contributor Author

Hi,
I would like to fix a few more inconsistencies but I wasn't able to generate the matter.d.ts file from the provided npm scripts. Do I need to manually update the file or am I missing something?

@photonstorm
Copy link
Collaborator

The types found in matter.d.ts are made by hand, there's no npm script for them.

@lukas-dachtler lukas-dachtler marked this pull request as ready for review March 6, 2024 23:30
@photonstorm photonstorm merged commit b8839e4 into phaserjs:master Sep 3, 2024
@photonstorm
Copy link
Collaborator

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@zekeatchan zekeatchan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lukas-dachtler @photonstorm @zekeatchan