AST validate that a contract does not have a function with contract name #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
onbjerg
requested changes
Nov 14, 2024
DaniPopes
reviewed
Nov 15, 2024
| if func_name.as_str() == contract_name { | ||
| self.dcx() | ||
| .err("functions are not allowed to have the same name as the contract") | ||
| .note("if you intend this to be a constructor, use \"constructor(...) { ... }\" to define it") |
There was a problem hiding this comment.
Suggested change
| .note("if you intend this to be a constructor, use \"constructor(...) { ... }\" to define it") | |
| .note("if you intend this to be a constructor, use `constructor(...) { ... }` to define it") |
| &item.kind | ||
| { | ||
| if let Some(func_name) = header.name { | ||
| if func_name.as_str() == contract_name { |
There was a problem hiding this comment.
Suggested change
| if func_name.as_str() == contract_name { | |
| if func_name == contract.name { |
Compare Symbols not strings, it has the same result but faster, which is the point of Symbol in the first place
| if let ast::ItemKind::Function(ast::ItemFunction { kind: _, header, body: _ }) = | ||
| &item.kind | ||
| { | ||
| if let Some(func_name) = header.name { |
There was a problem hiding this comment.
we need to also check that kind is Function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an AST validation check similar to this which verifies that a function does not have the same name as the contract.
Note, eventually this can be merged into a specific AST contract level checker.