-
-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove hifi screenshare (updated) #757
Remove hifi screenshare (updated) #757
Conversation
@HifiExperiments I incorporated your review comments into the last commit, please take a look! |
Windows build is failing for me with an unrecognized symbol:
|
Cherry picked and updated from Tivoli dd5b6ea6ee5597a06603e16509640e7ed18106bb Co-authored-by: Julian Groß <[email protected]>
214d101
to
1427c02
Compare
That was fixed in PR #756 Just rebased it on top of the latest code, that should do it. Sorry about that ^_^;; |
Interface builds now :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would suggest undoing the changes in the following files and moving them to a separate PR against the protocol_changes branch:
- EntityItemProperties.cpp/.h
- EntityPropertyFlags.h (just delete the prop entirely)
- ZoneEntityItem.cpp/.h (remove the ignoreUint32 thing)
- PacketHeaders.h (no need to rename the old version, just add a new version at the end)
with the ignoreUint32
hack, this might not crash, but it's not worth the complexity/risk imo.
hope you don't mind but I took the opportunity to rebase this once again and really remove the property and bump the protocol (on the protocol_changes branch): #1165 |
PR #435, rebased.
Original text below:
Closes #435