Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split load fields through nested phi nodes #21270

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

dhanalla
Copy link
Contributor

@dhanalla dhanalla commented Sep 30, 2024

This change is to Reduce Phi that has a child Phi as user and the child is only used for field loads.

Here are the sequence of Ideal graph transformations for Nested phi optimizations:

image

image

image

  1. Identify Nestedphi as potential candidate for optimization in ConnectionGraph::can_reduce_check_users
    ParentPhi->idx = 230
    Nestedphi->idx = 327

image

  1. Split through nestedphi node (Nestedphi->idx = 327) before parent phi node (ParentPhi->idx = 230) in ConnectionGraph::reduce_phi

image

  1. Split through parentphi node (ParentPhi->idx = 230) in ConnectionGraph::reduce_phi

image


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/21270/head:pull/21270
$ git checkout pull/21270

Update a local copy of the PR:
$ git checkout pull/21270
$ git pull https://git.openjdk.org/jdk.git pull/21270/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 21270

View PR using the GUI difftool:
$ git pr show -t 21270

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/21270.diff

@dhanalla dhanalla marked this pull request as draft September 30, 2024 16:23
@bridgekeeper
Copy link

bridgekeeper bot commented Sep 30, 2024

👋 Welcome back dhanalla! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Sep 30, 2024

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk
Copy link

openjdk bot commented Sep 30, 2024

@dhanalla The following label will be automatically applied to this pull request:

  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

1 participant