8334305: Remove all code for nsk.share.Log verbose mode #21267
Conversation
|
👋 Welcome back rsunderbabu! A progress list of the required criteria for merging this PR into |
|
@rsunderbabu This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 15 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@lmesnik) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
|
@rsunderbabu The following labels will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command. |
| @@ -315,16 +262,9 @@ public void trace(int level, Object message, Throwable exception) { | |||
|
|
|||
| /** | |||
| * Print <code>message</code> to the assigned output stream, | |||
There was a problem hiding this comment.
Need replace the comma with a period.
| if (!verbose()) { | ||
| doPrint(message); | ||
| } |
There was a problem hiding this comment.
Is this method ever called? Is there a CR to remove it (and any references to it)?
| @@ -406,10 +337,9 @@ private void logExceptionForFailureAnalysis(String msg) { | |||
| ///////////////////////////////////////////////////////////////// | |||
|
|
|||
| /** | |||
| * Redirect log to the given <code>stream</code>, and switch | |||
| * log mode to verbose. | |||
| * Redirect log to the given <code>stream</code> | |||
There was a problem hiding this comment.
Need period at end of sentence.
| * Prints errors summary to current stream, cancel current stream | ||
| * and switches to new stream. Turns on verbose mode for new stream. | ||
| * and switches to new stream. |
There was a problem hiding this comment.
Does it really do all this? It looks to me like it just switches to the new stream. I'm not sure what is meant by "error summary" and cancelling.
Cleaning up nsk.share.Log code after the verbose mode was set always true.
Tested all the vmTestbase/ tests.
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/21267/head:pull/21267$ git checkout pull/21267Update a local copy of the PR:
$ git checkout pull/21267$ git pull https://git.openjdk.org/jdk.git pull/21267/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 21267View PR using the GUI difftool:
$ git pr show -t 21267Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/21267.diff
Webrev
Link to Webrev Comment