Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8340907: Open source closed frame tests # 2 #21264

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

azvegint
Copy link
Member

@azvegint azvegint commented Sep 30, 2024

Few more tests to open source

Testing looks good.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8340907: Open source closed frame tests # 2 (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/21264/head:pull/21264
$ git checkout pull/21264

Update a local copy of the PR:
$ git checkout pull/21264
$ git pull https://git.openjdk.org/jdk.git pull/21264/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 21264

View PR using the GUI difftool:
$ git pr show -t 21264

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/21264.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 30, 2024

👋 Welcome back azvegint! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Sep 30, 2024

@azvegint This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8340907: Open source closed frame tests # 2

Reviewed-by: prr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 7 new commits pushed to the master branch:

  • bfdeb33: 8340332: Open source mixed AWT tests - Set3
  • a6b3188: 8337632: AES-GCM Algorithm optimization for x86_64
  • 5586f83: 8341064: Define anchor point and index term for "wrapper classes"
  • 4168faf: 8341100: Add index entries for terms used in java.lang.Class
  • f1bf469: 8341199: Use ClassFile's new API loadConstant(int)
  • 860d49d: 8211400: nsk.share.gc.Memory::getArrayLength returns wrong value
  • cff420d: 8339711: ZipFile.Source.initCEN needlessly reads END header

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the rfr Pull request is ready for review label Sep 30, 2024
@openjdk
Copy link

openjdk bot commented Sep 30, 2024

@azvegint The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@mlbridge
Copy link

mlbridge bot commented Sep 30, 2024

Webrevs

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client [email protected] ready Pull request is ready to be integrated rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

2 participants