8341176: Permit access to diagnostics for transient snippets

[lahodaj]

JShell permits to create transient snippets using SourceCodeAnalysis.sourceToSnippets, for the purpose of alternative UI clients. But, the alternative UI clients might need to get the diagnostics for the snippets, but the existing JShell.diagnostics(Snippet) will not work for the transient snippets.

This patch proposes to enhance the JShell.diagnostics(Snippet) with an ability to return best-effort diagnostics for these transient snippets.

Please also review the CSR:
https://bugs.openjdk.org/browse/JDK-8341200

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change requires CSR request JDK-8341200 to be approved

Issues

• JDK-8341176: Permit access to diagnostics for transient snippets (Enhancement - P3)
• JDK-8341200: Permit access to diagnostics for transient snippets (CSR)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/21261/head:pull/21261
$ git checkout pull/21261

Update a local copy of the PR:
$ git checkout pull/21261
$ git pull https://git.openjdk.org/jdk.git pull/21261/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 21261

View PR using the GUI difftool:
$ git pr show -t 21261

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/21261.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back jlahoda! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

[openjdk]

@lahodaj The following label will be automatically applied to this pull request:

• kulla

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (a8017a8c)