8341006: Optimize StackMapGenerator detect frames

[wenshao]

1. Construct Frames directly without BitSet
2. Use Frame[] instead of ArrayList
3. Use EMPTY_FRAME_ARRAY for initialization. No need to allocate objects when there is no frame.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8341006: Optimize StackMapGenerator detect frames (Sub-task - P4)

Reviewers

• Chen Liang (@liach - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/21183/head:pull/21183
$ git checkout pull/21183

Update a local copy of the PR:
$ git checkout pull/21183
$ git pull https://git.openjdk.org/jdk.git pull/21183/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 21183

View PR using the GUI difftool:
$ git pr show -t 21183

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/21183.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back swen! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@wenshao This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8341006: Optimize StackMapGenerator detect frames

Reviewed-by: liach

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 122 new commits pushed to the master branch:

• 21f8ccf: 8341310: Test TestJcmdWithSideCar.java should skip ACCESS_TMP_VIA_PROC_ROOT (after JDK-8327114)
• 7d524d7: 8341004: Open source AWT FileDialog related tests
• d7f32d8: 8341415: Optimize RawBytecodeHelper::next
• 6af1358: 8337753: Target class of upcall stub may be unloaded
• 19642bd: 8341148: Open source several Choice related tests
• 0b467e9: 8334060: Implementation of Late Barrier Expansion for G1
• c6e7e55: 8341091: CDS: Segmented roots array misses roots
• ff3e849: 8341239: Open source closed frame tests # 3
• 50ec169: 8341191: Open source few more AWT FileDialog tests
• 602408e: 8341177: Opensource few List and a Window test
• ... and 112 more: https://git.openjdk.org/jdk/compare/2e0554a69548dae6e8ce9eec48c82e08dd3c1ffa...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@wenshao The following label will be automatically applied to this pull request:

• core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 02: Full - Incremental (aa390010)
• 01: Full - Incremental (905acdda)
• 00: Full (0ea67959)

[liach]

The removal of bitset makes this frame detection significantly slower for startup. A heap sort or manual unrolling of bitset may be better.

Edit: the slowdown seems to be noise. I will investigate a bit more before leaving another review.

[liach]

This should be startup neutral.

[liach]

Thanks for this last-minute small change cleanup.

[wenshao]

/integrate

[openjdk]

Going to push as commit 1202800.
Since your change was applied there have been 123 commits pushed to the master branch:

• eb93e69: 8339979: VirtualThreadSchedulerMXBeanTest.testReduceParallelism fails intermittently
• 21f8ccf: 8341310: Test TestJcmdWithSideCar.java should skip ACCESS_TMP_VIA_PROC_ROOT (after JDK-8327114)
• 7d524d7: 8341004: Open source AWT FileDialog related tests
• d7f32d8: 8341415: Optimize RawBytecodeHelper::next
• 6af1358: 8337753: Target class of upcall stub may be unloaded
• 19642bd: 8341148: Open source several Choice related tests
• 0b467e9: 8334060: Implementation of Late Barrier Expansion for G1
• c6e7e55: 8341091: CDS: Segmented roots array misses roots
• ff3e849: 8341239: Open source closed frame tests # 3
• 50ec169: 8341191: Open source few more AWT FileDialog tests
• ... and 113 more: https://git.openjdk.org/jdk/compare/2e0554a69548dae6e8ce9eec48c82e08dd3c1ffa...master

Your commit was automatically rebased without conflicts.

[openjdk]

@wenshao Pushed as commit 1202800.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

[ExE-Boss]

@return on void method:

Suggested change

* @return detected frames