Unnecessary Variable Removal for Optimized computeIfAbsent Implementation

[dukbong]

Changes

• The computeIfAbsent method has been optimized by removing the newValue variable and reusing the v variable, thereby eliminating unnecessary local variable declarations.

Reason

• In the previous implementation, the newValue variable was used as an additional local variable without a specific purpose. By reusing the v variable, the code has been made more concise.

Impact

• This change simplifies the computeIfAbsent method in the Map interface by reducing unnecessary variable declarations. The existing behavior remains unchanged, and all functionality works as before.

Testing

• All existing test cases have passed successfully, confirming that this change does not affect current functionality.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Error

 ⚠️ OCA signatory status must be verified

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/21175/head:pull/21175
$ git checkout pull/21175

Update a local copy of the PR:
$ git checkout pull/21175
$ git pull https://git.openjdk.org/jdk.git pull/21175/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 21175

View PR using the GUI difftool:
$ git pr show -t 21175

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/21175.diff

[bridgekeeper]

Hi @dukbong, welcome to this OpenJDK project and thanks for contributing!

We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing /signed in a comment in this pull request.

If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user dukbong" as summary for the issue.

If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing /covered in a comment in this pull request.

[openjdk]

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

[openjdk]

@dukbong The following label will be automatically applied to this pull request:

• core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[dukbong]

Hi @dukbong, welcome to this OpenJDK project and thanks for contributing!

We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing /signed in a comment in this pull request.

If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user dukbong" as summary for the issue.

If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing /covered in a comment in this pull request.

/signed

[bridgekeeper]

Thank you! Please allow for up to two weeks to process your OCA, although it is usually done within one to two business days. Also, please note that pull requests that are pending an OCA check will not usually be evaluated, so your patience is appreciated!

[liach]

I believe you have misunderstood object creation. Declaring a local variable leaves that variable in its default value, which is null for reference types, meaning there is no allocation. What your patch reduces is redundant local variable declarations.

[dukbong]

I believe you have misunderstood object creation. Declaring a local variable leaves that variable in its default value, which is null for reference types, meaning there is no allocation. What your patch reduces is redundant local variable declarations.

Thank you! I mistakenly referred to the local variable as object creation. I have revised my comment accordingly.

[bridgekeeper]

@dukbong This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!