Visually distinguish invitations in calendar grid #6624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Grigory Vodyanov <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6624 +/- ##
=============================================
+ Coverage 23.17% 59.30% +36.12%
- Complexity 472 475 +3
=============================================
Files 250 42 -208
Lines 12020 2290 -9730
Branches 2296 0 -2296
=============================================
- Hits 2786 1358 -1428
+ Misses 8907 932 -7975
+ Partials 327 0 -327
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
st3iny
reviewed
Jan 14, 2025
Comment on lines
+40
to
+57
| if (object.status && object._properties.size > 9) { | ||
| let didEveryoneDecline = true; | ||
| for (const [key, value] of object._properties.entries()) { | ||
| if (key === 'ATTENDEE') { | ||
| value.forEach((attendee) => { | ||
| for (const [key, value] of attendee._parameters.entries()) { | ||
| if (key === 'PARTSTAT') console.log('key', key, value._value) | ||
| if (key === 'PARTSTAT' && value._value !== 'DECLINED') { | ||
| didEveryoneDecline = false; | ||
| } | ||
| } | ||
| }) | ||
| } | ||
| } | ||
| if (didEveryoneDecline) { | ||
| classNames.push('fc-event-nc-all-declined') | ||
| } | ||
| } |
There was a problem hiding this comment.
The data you need is already exposed by calendar-js. Take a look at the following pseudo-code:
for (const attendeeProperty of object.getPropertyIterator('ATTENDEE')) {
const hasDeclined = attendeeProperty.participationStatus === 'DECLINED'
// TODO: write the rest of the code
}There was a problem hiding this comment.
And to check if there are attendees you could use:
object.hasProperty('ATTENDEE')
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #3869