-
Notifications
You must be signed in to change notification settings - Fork 418
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reformated to be a proper package #10
Conversation
Thanks a lot, just tested and it seems to work for me too! Good call on squashing, I prefer that too. Few minor comments:
|
Oh, and if you write something like "Fixes #9" into the commit message, github will automatically close that issue when merging this PR. |
Just updated my branch with these changes. I had problems with github and squashed commits (I am not a git guru, more of a hg guy), so I ended having "repeated commits". |
Just noticed a minor change lost in my git fights. Pushed back as one extra commit. |
Merged manually with clean history, See c0550af, 19119d3, and 1463feb. If you want to take credit, I recommend you associate the e-mail address that you committed with ( |
Also, closing manually since it looks like github doesn't auto-detect manual merges. |
Thanks a lot for sharing this with us! |
Here is my pull request to address issue #9.
I squashed all my mini-changes into a big commit (other repositories like to do that).
I tried a fresh install into a virtualenv and it seemed to work fine. So unless I messed-up with my git manipulations, this should solve the issue.
Note that setup.py will also install pydensecrf.util as required.
I created my own playground applications to use it. Maybe
util_inference_example.py
should be moved of the package, and have it callimport pydensecrf.densecrf
andimport pydensecrf.utils
; so as to show the proper use of the library.