Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Overrides default Lua print with tracing alternative #283

Merged
merged 1 commit into from
Oct 6, 2023
Merged

Overrides default Lua print with tracing alternative #283

merged 1 commit into from
Oct 6, 2023

Conversation

cipharius
Copy link
Contributor

In attempt to improve the appl debugging sittuation, this provides custom Lua print function and augments it with tracing support.

@cipharius
Copy link
Contributor Author

The empty print case is still not satisfactory, will fix it first.

@cipharius
Copy link
Contributor Author

No more dancing around fixed, mutable string prefix. Now works well

letoram
letoram requested changes Sep 16, 2023
View reviewed changes
Copy link
Owner

@letoram letoram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a better fit in src/engine/alt/trace.c as _lua.c will slowly be split out into that.

@cipharius cipharius requested a review from letoram October 4, 2023 09:55
@letoram letoram merged commit 07baa1f into letoram:master Oct 6, 2023
2 checks passed
@cipharius cipharius deleted the feature/lua-print-tracing branch October 6, 2023 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@letoram letoram Awaiting requested review from letoram

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cipharius @letoram