Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(observability): fix bugs found from product review + negative cases #2158

Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
More test failure debugs
  • Loading branch information
odeke-em committed Oct 24, 2024
commit bea444c3ba4dae5e040be4a8f01106e57a641854
5 changes: 0 additions & 5 deletions observability-test/spanner.ts
Original file line number Diff line number Diff line change
Expand Up @@ -172,7 +172,6 @@ describe('EndToEnd', () => {
await tracerProvider.forceFlush();
await tracerProvider.shutdown();
traceExporter.reset();
database.close();
spannerMock.resetRequests();
spanner.close();
server.tryShutdown(() => {});
Expand Down Expand Up @@ -822,10 +821,6 @@ describe('ObservabilityOptions injection and propagation', async () => {
db.formattedName_
);

after(() => {
db.close();
});

it('run', done => {
database.getTransaction((err, tx) => {
assert.ifError(err);
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@
"system-test": "mocha build/system-test --timeout 1600000",
"observability-test": "mocha build/observability-test --timeout 1600000",
"cleanup": "mocha scripts/cleanup.js --timeout 30000",
"test": "mocha build/test build/test/common build/observability-test",
"test": "mocha build/test build/test/common build/observability-test --trace-warnings --timeout 1600000",
"ycsb": "node ./benchmark/ycsb.js run -P ./benchmark/workloada -p table=usertable -p cloudspanner.instance=ycsb-instance -p operationcount=100 -p cloudspanner.database=ycsb",
"fix": "gts fix",
"clean": "gts clean",
Expand Down