Move fonts to new structure #1490
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…aterialIcons-Regular.codepoints
Explain where the files formerly here have been moved to.
2bndy5
reviewed
Mar 17, 2023
font/README.md
Outdated
|
|
||
| Material Icons are the non-variable classic icon fonts, while the Material Symbols variable fonts offer weight, optical size, grade and fill variations (with grade and Fill being intended also for animated effects). | ||
| The Material Symbols variable fonts offer weight, optical size, grade and fill variations (with grade and Fill being intended also for animated effects). Material Symbols are the non-variable classic icon fonts, while |
There was a problem hiding this comment.
Paragraph ends in an incomplete sentence (resulting from copy-n-paste I think)
There was a problem hiding this comment.
Thanks! Fixed.
(Also fixed a code snippet that referenced the font incorrectly.)
lnsantos
approved these changes
Feb 2, 2024
omkarkulkarni2704
approved these changes
Dec 5, 2024
|
|
||
| ```html | ||
| <!-- https://material.io/resources/icons/?style=baseline --> | ||
| <link href="https://fonts.googleapis.com/css2?family=Material+Icons" |
There was a problem hiding this comment.
The issue is in the first tag for Material Icons, which is missing a closing >; it should be:
<link href="https://fonts.googleapis.com/css2?family=Material+Icons" rel="stylesheet">
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per discussions with SeHee and Islam, moving the variable fonts (Material Symbols) from "variablefonts" into the main "fonts" dir, creating a subdirectory for Material Icons (old non-variable fonts).
This is intended to solve the problem that people don’t realize there is a separate location at the end of the list for the variable fonts, and go to the first thing they see that looks correct which is "fonts"