Address a missing declaration warning to improve signal #3910
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derekmauro
reviewed
Jun 27, 2022
| @@ -68,6 +68,8 @@ namespace internal { | |||
| // mockers, and all expectations. | |||
| GTEST_API_ GTEST_DEFINE_STATIC_MUTEX_(g_gmock_mutex); | |||
|
|
|||
| CallReaction intToCallReaction(int mock_behavior); | |||
There was a problem hiding this comment.
Since this function is only called from this file, it does not need a declaration. It only needs to be declared static of be placed in the anonymous namespace to suppress the warning.
There was a problem hiding this comment.
I notice the function is named intToCallReaction. Would you also want me to use IntToCallReaction instead based on the convention I see throughout the file?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#3909