updatekeys subcommand: show changes in shamir_threshold #1609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3bbe26f
to
b16be8d
Compare
0458672
to
097500a
Compare
hiddeco
approved these changes
Sep 25, 2024
Signed-off-by: Felix Fontein <[email protected]>
097500a
to
9992c8e
Compare
|
@jorn-ola-birkeland @hiddeco thanks for reviewing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspired by #1509. Also fixes that changes in the Shamir threshold are detected (when the command line flag is used, see #1608).
This does not change the behavior which Shamir threshold is actually used (see the
TODOcomment), that raised the original change in #1509. I'm currently thinking that it should be the user's choice and that should be added as a feature, not a bugfix.