Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.5.0 #32

Merged
merged 438 commits into from
Jul 3, 2024
Merged
Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
438 commits
Select commit Hold shift + click to select a range
b168ca5
table height on two columns view (wide screen) is fixed
Jun 14, 2024
8316495
Merged PR 2736: Responsive incident summary view
Jun 14, 2024
c23da71
breaking column name if it is too long
psychologianauki Jun 14, 2024
83a3fd6
Merged PR 2737: 12170 breaking column name if it is too long
Jun 14, 2024
0dc59fe
unified size of table quality status
psychologianauki Jun 14, 2024
1752450
added border correctly and minimalized the margin
psychologianauki Jun 14, 2024
ee9dfc1
displaying white default background and changing it when providing la…
psychologianauki Jun 14, 2024
227c9bd
Merged PR 2738: 12201 unified size of table quality status boxes (adj…
Jun 14, 2024
702a64e
moved refresh button max to the left
psychologianauki Jun 14, 2024
cfc6f06
First group of classes for error sampling.
piotrczarnas Jun 16, 2024
4d6f1b4
Error sampler jobs defined.
piotrczarnas Jun 16, 2024
65dc418
CLI command "collect errorsamples" to allow running error sampling.
piotrczarnas Jun 16, 2024
63b545a
Operations to start a collect error samples job added to the jobs con…
piotrczarnas Jun 16, 2024
6e4f203
Update swagger files with new operations in the jobs controller to st…
piotrczarnas Jun 16, 2024
635bd3a
added refresh button to incidents summary view
Jun 17, 2024
0600e11
fixed duckdb schema tests
Jun 17, 2024
b4b99d8
Merged PR 2739: added refresh button to incidents summary view
Jun 17, 2024
693410e
Merged PR 2740: fixed duckdb schema tests
Jun 17, 2024
a9999e2
running tests on json file with use of duckdb
Jun 17, 2024
79086dc
running tests on parquet file with use of duckdb
Jun 17, 2024
3f0d65f
Merge branch 'develop' of https://dev.azure.com/imagetemplates/documa…
Jun 17, 2024
4bab44f
Merged PR 2741: Duckdb rund on json and parquet files - only volume …
Jun 17, 2024
b113873
setting id on columnSpec on column presence in INFORMATION_SCHEMA.KEY…
Jun 17, 2024
5ff6bee
swallowing sql exception when unable to retrieve data from INFORMATIO…
Jun 17, 2024
7c60708
Merged PR 2742: setting id on columnSpec on column presence in INFORM…
Jun 17, 2024
8da178b
Table status cache race condition fixed.
piotrczarnas Jun 17, 2024
133f4ff
Initial implementation of error sampling.
piotrczarnas Jun 17, 2024
dbdf2c8
Error sampler works from the command line, for one sample type so far.
piotrczarnas Jun 17, 2024
866d899
sql server added missing integrity integration tests
Jun 18, 2024
b468b0b
fixed extension from wrong base class
Jun 18, 2024
d946169
Merged PR 2743: missing sql server integration tests implemented
Jun 18, 2024
363a051
timeliness data freshness anomaly
Jun 18, 2024
99d3a12
Updated date selection tooltip
Jun 18, 2024
437d9f9
Merge remote-tracking branch 'origin/develop' into develop
Jun 18, 2024
73a7429
Merged PR 2744: timeliness data freshness anomaly
Jun 18, 2024
b263770
Table comparison rest api supports configuration of WHERE filters.
piotrczarnas Jun 18, 2024
dd67b14
Merge branch 'develop' of https://dev.azure.com/imagetemplates/documa…
piotrczarnas Jun 18, 2024
67ca310
Swagger updated to support configuration of WHERE filters for table c…
piotrczarnas Jun 18, 2024
d7d5e60
Design of implementing all rest api operations as asynchronous, to av…
piotrczarnas Jun 18, 2024
13c2072
tests for listTables with tableNameContains argument
Jun 18, 2024
d11dc87
duckdb tests for listTables with tableNameContains argument, moved du…
Jun 18, 2024
7c872d5
Merged PR 2745: Tests for listTables with tableNameContains argument
Jun 18, 2024
04e02af
Displaying spinner on IncidentConnections if results are loading
psychologianauki Jun 18, 2024
e74abe4
the whole rest api is async, all controllers return Mono<>
Jun 18, 2024
5d315cb
Merge branch 'develop' of https://dev.azure.com/imagetemplates/documa…
psychologianauki Jun 18, 2024
70e8c53
displaying tabs correctly with fixed position
psychologianauki Jun 18, 2024
f9ad816
unit tests updated to async api
Jun 18, 2024
c2e683e
improved clicking on tabs
psychologianauki Jun 18, 2024
34d49f3
Merged PR 2746: 12079 Displaying spinner on IncidentConnections if re…
Jun 18, 2024
e1d9685
fixed delay when providing expected values in ui
psychologianauki Jun 18, 2024
3b69aee
Merged PR 2747: the whole rest api is async, all controllers return M…
Jun 18, 2024
32d3e6f
fixed date select with enum values
psychologianauki Jun 18, 2024
8481aee
Merged PR 2748: 12208 displaying tabs correctly with fixed position o…
Jun 18, 2024
644caf4
Merged PR 2749: 11672 fixed delay when providing expected values in ui
Jun 18, 2024
87744e2
Merged PR 2750: 12226 fixed date select with enum values
Jun 18, 2024
6d5951f
Unit tests for rendering table sampling queries with groupings and id…
piotrczarnas Jun 18, 2024
90d7d17
Integration tests for one error sampling sensor on bigquery.
piotrczarnas Jun 18, 2024
d39a931
removed colons from texts, labels in ui
Jun 19, 2024
c873bfc
error sampling - all db except for oracle
Jun 19, 2024
10918e0
Merged PR 2751: removed colons from texts, labels in ui
Jun 19, 2024
b8a8f38
If the data is outdated or inactive, displaying warning accordingly
psychologianauki Jun 19, 2024
94a396f
Merged PR 2752: 12145 If the data is outdated or inactive, displaying…
Jun 19, 2024
e3101f9
error sampling - oracle
Jun 19, 2024
8068ab0
Merged PR 2753: Error sampling templates for all DBs
Jun 19, 2024
a03941b
Added description of the Incidents summary to the documentation
Jun 19, 2024
77afd23
Rest api for editing sensor definition updated to edit also error sam…
piotrczarnas Jun 19, 2024
f171a31
Merge branch 'develop' of https://dev.azure.com/imagetemplates/documa…
piotrczarnas Jun 19, 2024
6658678
Updated documentation after recent changes
Jun 19, 2024
d33a0e8
Merge remote-tracking branch 'origin/develop' into develop
Jun 19, 2024
3ace629
error sampling templates for column/numeric/invalid_latitude_count
Jun 19, 2024
b12403b
Column list model returns a flag that identifies columns that are ide…
piotrczarnas Jun 19, 2024
e33d4ee
fix: error sampling templates for column/numeric/invalid_latitude_count
Jun 19, 2024
7bea7c5
error sampling templates for column/numeric/invalid_longitude_count
Jun 19, 2024
c5ace89
error sampling templates for column/numeric/ mean, negative, non nega…
Jun 19, 2024
a10b61f
getting results and saving them locally on incident section
psychologianauki Jun 19, 2024
49a5373
fixed changing month and dataGrouping
psychologianauki Jun 19, 2024
2388697
error sampling templates for column/numeric/ above max, below min, pe…
Jun 20, 2024
5ea76ce
error sampling templates for column/numeric/ data calculated through …
Jun 20, 2024
4448311
error sampling templates for column/numeric/ valid longitude latitude
Jun 20, 2024
09b7a49
Merged PR 2754: 12149 getting results and saving them locally on inci…
Jun 20, 2024
629e21f
error sampling templates for column/null, error sampling templates nu…
Jun 20, 2024
31a28b1
Reordering operations in the error sampling service to delay creating…
piotrczarnas Jun 20, 2024
9db474a
Merge branch 'develop' of https://dev.azure.com/imagetemplates/documa…
piotrczarnas Jun 20, 2024
7078f3e
Showing the hint about the count of issues also on the incident detai…
piotrczarnas Jun 20, 2024
bfa3f17
Make the disable/recalibrate/configure incident buttons bigger.
piotrczarnas Jun 20, 2024
66b9c9f
duckdb text not matching date pattern count sensor fixed
Jun 21, 2024
9467512
added id column to test data
Jun 21, 2024
32e69f3
error sampling templates for column/patterns
Jun 21, 2024
1f10830
loading tables functionality init
psychologianauki Jun 21, 2024
6aa213c
moved bigquery jinja sensor marcos to dialect file, integration tests…
Jun 21, 2024
52e427f
searching tables func
psychologianauki Jun 21, 2024
c60ce9a
Documentation and python client updated.
piotrczarnas Jun 23, 2024
b719e09
moved render date macro to dialect for each of db, mysql regex fix in…
Jun 24, 2024
52c36e7
added oracle binary double type
Jun 24, 2024
cd638fa
integration test adjustment
Jun 24, 2024
5d14e2a
bugfixes
Jun 24, 2024
874bc4a
Small fix in the Data timeliness checks description in the documentation
Jun 24, 2024
866a6c1
error sampling templates for column/pii
Jun 24, 2024
60910b2
Merge branch 'develop' of https://dev.azure.com/imagetemplates/documa…
psychologianauki Jun 24, 2024
de296df
filtering tables in tree functionality
psychologianauki Jun 24, 2024
27d7e9e
Merged PR 2755: filtering tables in tree functionality
Jun 24, 2024
f1b3e8e
error sampling templates for column/range
Jun 25, 2024
01259ce
error sampling templates for column/text
Jun 25, 2024
a2000b7
id field column detail
psychologianauki Jun 25, 2024
06b3c13
Merged PR 2756: 12318 id field column detail
Jun 25, 2024
93a1011
added key id icon
psychologianauki Jun 25, 2024
1db17c4
Merge branch 'develop' of https://dev.azure.com/imagetemplates/documa…
psychologianauki Jun 25, 2024
c62af30
displaying key svg if column has id enabled
psychologianauki Jun 25, 2024
58a7e76
error sampling templates for column/whitespace
Jun 25, 2024
ab169f6
error sampling templates for column/datetime
Jun 25, 2024
4dd32fd
error sampling templates for column/customsql
Jun 25, 2024
2d1253a
Merged PR 2757: 12316 displaying key svg if column has id enabled
Jun 25, 2024
5c5829a
improved delete data quality results popup
psychologianauki Jun 25, 2024
d411234
displaying filters if user clicks on funnel
psychologianauki Jun 25, 2024
200f0e7
fixed component responsible for searching for tables
psychologianauki Jun 25, 2024
80b20b3
sql where expression comparison table
psychologianauki Jun 25, 2024
fab88df
Merged PR 2758: 12248 improved delete data quality results popup
Jun 25, 2024
03fc225
Merged PR 2759: displaying filters if user clicks on funnel
Jun 25, 2024
b452df5
Rest api to return error samples.
piotrczarnas Jun 25, 2024
4e0e61d
Error sampling is started after running checks.
piotrczarnas Jun 25, 2024
beb1006
error sampling templates for column/conversions, parsable to int and …
Jun 26, 2024
a9499d5
updating sql filter in ui works correctly
psychologianauki Jun 26, 2024
3e2cfa8
error sampling templates for column/bool
Jun 26, 2024
1f1b973
displaying textareas instead of inputs
psychologianauki Jun 26, 2024
bf4bdc8
Updated Incidents concept documentation
Jun 26, 2024
bf382f5
Merged PR 2760: sql where expression comparison table
Jun 26, 2024
1e9c774
closing popup after clicking 'Ok' button correctly
psychologianauki Jun 26, 2024
ab07760
Merged PR 2761: 12218 closing popup after clicking 'Ok' button correctly
Jun 26, 2024
e6d9cf2
error sampling templates for column/accepted values - country and cur…
Jun 26, 2024
19a79d9
decresed size of funnel and incresed z-index of userprofile and notif…
psychologianauki Jun 26, 2024
1c85d74
Small fixes to pass the "collect error samples" boolean flag from the…
piotrczarnas Jun 26, 2024
e42f7d7
Merged PR 2762: decresed size of funnel and incresed z-index of userp…
Jun 26, 2024
4e65947
added error sampling template to sensorDetail section
psychologianauki Jun 26, 2024
8e318c8
Updated tooltips for timeliness and partition checks without properly…
Jun 26, 2024
29b44f5
error sampling templates for column/accepted values - the rest
Jun 26, 2024
426393b
Small update in date partitioning column configuration label
Jun 26, 2024
870b8eb
unified menus of all selects
psychologianauki Jun 26, 2024
c0e971f
closing menu if user clicks somewhere on the screen
psychologianauki Jun 26, 2024
705a867
Merged PR 2764: added error sampling template to sensorDetail section
Jun 26, 2024
879c695
Merged PR 2765: unified menus of all selects & closing menu if user c…
Jun 26, 2024
e94ecd9
fixed position of context menu in the tree
psychologianauki Jun 26, 2024
96f67db
Some fixes in the hadoop configuration settings.
piotrczarnas Jun 26, 2024
00717b9
Additional code to test waiting for the system initialization.
piotrczarnas Jun 26, 2024
82ed87f
Merged PR 2767: 12350 fixed position of context menu in the tree
Jun 26, 2024
74a379a
Race condition fixed for loading Hadoop configuration. Parquet reader…
piotrczarnas Jun 26, 2024
49e8599
Merge branch 'develop' of https://dev.azure.com/imagetemplates/documa…
piotrczarnas Jun 26, 2024
a21c3a2
Different method of waiting for the table cache load, using a separat…
piotrczarnas Jun 26, 2024
9be1081
fixes related to failed bigquery integration tests
Jun 27, 2024
5d11392
failed mysql integration tests fix
Jun 27, 2024
a43e045
failed oracle integration tests fix
Jun 27, 2024
ea43215
failed postgresql integration tests fix
Jun 27, 2024
6948ced
text_length_in_range_percent bugfix
Jun 27, 2024
267d724
failed presto integration tests
Jun 27, 2024
55b589a
failed spark integration tests fixed
Jun 27, 2024
22f3d1e
databricks integration tests fixed based on spark changes
Jun 27, 2024
f25ac65
sqlserver integration tests fixed
Jun 27, 2024
cd0f1e2
updated sql format check tests
Jun 27, 2024
c8747a2
Merged PR 2768: Error sampling
Jun 27, 2024
d89d465
error samples functionality init
psychologianauki Jun 27, 2024
cc1f66e
Version number upgrade to 1.5.0
piotrczarnas Jun 27, 2024
5ba3e20
errorSamplesTab component
psychologianauki Jun 27, 2024
bd17968
Merge branch 'develop' of https://dev.azure.com/imagetemplates/documa…
psychologianauki Jun 27, 2024
48ec67e
conversion sensors to float and to integer fixed
Jun 27, 2024
6820db3
assigned errorSamples to tab state
psychologianauki Jun 27, 2024
7631b00
Merged PR 2769: conversion sensors to float and to integer fixed
Jun 27, 2024
3e11a16
displaying errorsamles correctly
psychologianauki Jun 27, 2024
314095f
simplified the duckdb related doc file
Jun 27, 2024
b06b8bc
error samples on incident section init
psychologianauki Jun 27, 2024
afac07e
Merged PR 2770: 12354 error samples UI
Jun 27, 2024
4f0549f
collect error samples boolean flag in runchecks dialog
psychologianauki Jun 27, 2024
8e62053
Merged PR 2771: 12352 collect error samples boolean flag in runchecks…
Jun 27, 2024
6453f9d
Error samples data service changed to iterate over partitions and sto…
piotrczarnas Jun 27, 2024
545a65f
layout changes ui
psychologianauki Jun 28, 2024
a0f4a5c
Merged PR 2772: 12367 layout changes ui
Jun 28, 2024
8c71472
the datatype sensor's float regex accepts ints also
Jun 28, 2024
9bb1f28
fixed opening table columns node
psychologianauki Jun 28, 2024
ce1ae78
branch init
psychologianauki Jun 28, 2024
f731ff1
.
psychologianauki Jun 28, 2024
0d94ad4
the datatype error sampling VIP
Jun 28, 2024
723e9f8
handled displaying firstLevelTab on homePage
psychologianauki Jun 28, 2024
5f9d409
Merged PR 2773: 12370 fixed opening table columns node
Jun 28, 2024
44035b1
Fix backend issue to detect checks without data sampling support.
piotrczarnas Jun 28, 2024
266c98c
Merge branch 'develop' of https://dev.azure.com/imagetemplates/documa…
piotrczarnas Jun 28, 2024
982eeb2
the datatype error sampling
Jun 28, 2024
6e97342
presto regex fiix
Jun 28, 2024
cce4aa9
enabled to save definitions directly after copying them
psychologianauki Jun 29, 2024
8540c7d
fixed sorting direction on defaultCheck pattern page
psychologianauki Jun 29, 2024
a3bb10c
opening new incident connection level tab from url with clear cache w…
psychologianauki Jun 29, 2024
f5ea7c0
deleted add column button from single column page
psychologianauki Jun 29, 2024
70343cd
preventing wrong tab mapping from source to monitoring/partitioned/pr…
psychologianauki Jun 29, 2024
aa30e5d
adding tab value correctly to firstLevelTab
psychologianauki Jun 29, 2024
a97b5fa
align digits right on table quality status totalChecksExeculted section
psychologianauki Jun 29, 2024
347ceb2
Merged PR 2775: 12377 enabled to save definitions directly after copy…
Jun 29, 2024
4d90153
Merged PR 2776: 12380 fixed sorting direction on defaultCheck pattern…
Jun 29, 2024
e0682aa
Merged PR 2777: 12381 opening new incident connection level tab from …
Jun 29, 2024
43e204b
Merged PR 2778: 12382 deleted add column button from single column page
Jun 29, 2024
e63091e
Merged PR 2779: 12382 preventing wrong tab mapping from source to mon…
Jun 29, 2024
6e85ef7
Merged PR 2780: 12384 adding tab value correctly to firstLevelTab whe…
Jun 29, 2024
cbbb441
Merged PR 2781: 12385 align digits right on table quality status tota…
Jun 29, 2024
db52860
placed ref correctly to avoid closing menu unnecessary
psychologianauki Jun 29, 2024
e20bedb
closing <SelectInput /> when clicking outside component
psychologianauki Jun 29, 2024
9508143
Merged PR 2782: 12386 placed ref correctly to avoid closing menu unne…
Jun 29, 2024
1033f1f
fixed 'import metadata button'
psychologianauki Jun 30, 2024
259c0c4
deleted consolelog
psychologianauki Jun 30, 2024
7b2b830
not displaying button on screen 'schemas?import_schema=true'
psychologianauki Jun 30, 2024
2431c02
Merged PR 2783: fixed 'import metadata button'
Jun 30, 2024
2172f30
replaced CTE with nested select in render_error_sampler macro
Jul 1, 2024
155cbd4
working with files docs page
Jul 1, 2024
a30540e
comparing firstLevelActiveTab to value to avoid opening empty tab
psychologianauki Jul 1, 2024
de74464
integrity missing keys error sampling for duckdb
Jul 1, 2024
f320b21
fixed opening tab by clicking on header
psychologianauki Jul 1, 2024
21bba10
Merged PR 2784: Datatype sensors error sampling
Jul 1, 2024
1db5fce
Merged PR 2785: Completed the docs of the working with files
Jul 1, 2024
43238d9
Merged PR 2786: comparing firstLevelActiveTab to value to avoid openi…
Jul 1, 2024
ec12f0d
added error sampling for the integrity sensors category
Jul 1, 2024
f79c818
merge
Jul 1, 2024
4788bc1
Merged PR 2787: Integrity category error sampling
Jul 1, 2024
a0504fd
duckdb uniqueness error sampling
Jul 1, 2024
28a1cbc
uniqueness error sampling finished
Jul 1, 2024
1b41868
Merged PR 2788: Error sampling - uniqueness
Jul 1, 2024
cb3295b
oracle date patterns match sensors fixed
Jul 1, 2024
0f4968a
increased size of select component to keep same size of main field an…
psychologianauki Jul 1, 2024
c6f7d53
Merged PR 2790: 12258 increased size of select component to keep same…
Jul 1, 2024
0542014
closing 'new tab' on sensor/rule pages correctly after clicking save
psychologianauki Jul 1, 2024
d0cd312
oracle conversion to date sensor uses regex
Jul 2, 2024
ca50dc3
oracle conversion to date handles comma space in BDY format
Jul 2, 2024
373771f
postgresql patterns matching date use regexes instead of to_date func…
Jul 2, 2024
c52ad52
Merged PR 2791: 12379 closing 'new tab' on sensor/rule pages correctl…
Jul 2, 2024
807edfb
patterns matching date unification, runs on mixed type rows
Jul 2, 2024
cafc943
duckdb datatype bugfix: int values are recognized by float type
Jul 2, 2024
290810f
removed invalidly copied test cases
Jul 2, 2024
d802271
bugfix: oracle pattens integration tests columns and asserts
Jul 2, 2024
61d234d
sqlserver datatype error sampling fixed, sql server does not use cte …
Jul 2, 2024
21612e5
Merged PR 2792: to_date fixed, minor sensor fixes to oracle, duckdb, …
Jul 2, 2024
7e2275f
searching for column functionality init
psychologianauki Jul 2, 2024
db2253a
clicking on senstions on header with clean cache works correctly
psychologianauki Jul 2, 2024
f74302d
Merged PR 2793: clicking on senstions on header with clean cache work…
Jul 2, 2024
424e794
Merge branch 'develop' of https://dev.azure.com/imagetemplates/documa…
psychologianauki Jul 2, 2024
711e376
searching columns functionality
psychologianauki Jul 2, 2024
6609e0a
extending node if clicked on funnel
psychologianauki Jul 2, 2024
6752214
Merged PR 2794: Filtering columns in tree
Jul 2, 2024
715bc39
Documentation an python client regenerated for the version 1.5.0
piotrczarnas Jul 2, 2024
b70ce14
error samples delete service
Jul 3, 2024
04bfb6d
Merged PR 2795: error samples delete service
Jul 3, 2024
4882480
DuckDB render_date_format_regex
Jul 3, 2024
682ad04
CLI docs, fix sanitizing generic classes that append a 'self' property
Jul 3, 2024
7b971bc
:mm placeholder in rest models descriptions fix
Jul 3, 2024
6a79c45
Docs YAML fix, render 'self' property of generic derived classes
Jul 3, 2024
1e88f51
Merged PR 2797: Correction of most visible mistakes in generated docs
Jul 3, 2024
d767509
Documentation regenerated with some recent fixes.
piotrczarnas Jul 3, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -129,6 +129,7 @@ export const IncidentsNotificationsView = () => {
value={incidentGrouping?.grouping_level}
onChange={(value) => onChange({ grouping_level: value })}
className="text-sm"
menuClassName="!top-14"
/>
</div>
<div className="flex mb-4">
Expand All @@ -138,6 +139,7 @@ export const IncidentsNotificationsView = () => {
value={incidentGrouping?.minimum_severity}
onChange={(value) => onChange({ minimum_severity: value })}
className="text-sm"
menuClassName="!top-14"
/>
</div>
<div className="flex gap-4 items-center mb-4 text-sm">
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,7 @@ const BigqueryConnection: React.FC<IBigqueryConnectionProps> = ({
disabled={userProfile.can_manage_data_sources !== true}
onClickValue={setSelectedInput}
selectedMenu={selectedInput}
menuClassName="!top-14"
/>
<Select
label="GCP project to create BigQuery jobs, where the authenticated principal has bigquery.jobs.create permission"
Expand All @@ -91,6 +92,7 @@ const BigqueryConnection: React.FC<IBigqueryConnectionProps> = ({
disabled={userProfile.can_manage_data_sources !== true}
onClickValue={setSelectedInput}
selectedMenu={selectedInput}
menuClassName="!top-14"
/>
<FieldTypeInput
className="mb-4"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ const storageTypeOptions = [
{
label: 'Google Cloud Storage',
value: DuckdbParametersSpecStorageTypeEnum.gcs
},
}
// todo: uncomment below when implemented
// {
// label: 'Cloudflare R2',
Expand Down Expand Up @@ -85,9 +85,9 @@ const azureAuthenticationOptions = [
];

enum StoragePrefixes {
S3 = "s3://",
AZ = "az://",
GCS = "gs://",
S3 = 's3://',
AZ = 'az://',
GCS = 'gs://'
}

const DuckdbConnection = ({
Expand Down Expand Up @@ -145,11 +145,11 @@ const DuckdbConnection = ({
const directories = { ...copiedDatabase?.directories };

Object.keys(directories ?? {}).forEach((key) => {

if (directories[key].length
&& directories[key] !== StoragePrefixes.S3
&& directories[key] !== StoragePrefixes.AZ
&& directories[key] !== StoragePrefixes.GCS
if (
directories[key].length &&
directories[key] !== StoragePrefixes.S3 &&
directories[key] !== StoragePrefixes.AZ &&
directories[key] !== StoragePrefixes.GCS
) {
return;
}
Expand All @@ -163,7 +163,6 @@ const DuckdbConnection = ({
} else {
directories[key] = '';
}

});
setCopiedDatabase((prev) => ({ ...prev, directories, storage_type }));
};
Expand Down Expand Up @@ -241,8 +240,8 @@ const DuckdbConnection = ({
/>
)}
</>
)
}
);
};

const azureStorageForm = (): JSX.Element => {
return (
Expand Down Expand Up @@ -277,7 +276,7 @@ const DuckdbConnection = ({
/>
</>
)}

{copiedDatabase?.azure_authentication_mode ===
DuckdbParametersSpecAzureAuthenticationModeEnum.credential_chain && (
<>
Expand Down Expand Up @@ -336,8 +335,8 @@ const DuckdbConnection = ({
</>
)}
</>
)
}
);
};

const googleStorageForm = (): JSX.Element => {
return (
Expand All @@ -362,8 +361,8 @@ const DuckdbConnection = ({
}
/>
</>
)
}
);
};

return (
<SectionWrapper
Expand All @@ -378,13 +377,17 @@ const DuckdbConnection = ({
onChange={changeStorageTypeDirectoryPrefixes}
onClickValue={setSelectedInput}
selectedMenu={selectedInput}
menuClassName="!top-14"
/>

{copiedDatabase?.storage_type === DuckdbParametersSpecStorageTypeEnum.s3 && awsStorageForm()}
{copiedDatabase?.storage_type ===
DuckdbParametersSpecStorageTypeEnum.s3 && awsStorageForm()}

{copiedDatabase?.storage_type === DuckdbParametersSpecStorageTypeEnum.azure && azureStorageForm()}
{copiedDatabase?.storage_type ===
DuckdbParametersSpecStorageTypeEnum.azure && azureStorageForm()}

{copiedDatabase?.storage_type === DuckdbParametersSpecStorageTypeEnum.gcs && googleStorageForm()}
{copiedDatabase?.storage_type ===
DuckdbParametersSpecStorageTypeEnum.gcs && googleStorageForm()}

<FileFormatConfiguration
fileFormatType={
Expand Down Expand Up @@ -422,7 +425,6 @@ const DuckdbConnection = ({
/>
</SectionWrapper>
);

};

export default DuckdbConnection;
Original file line number Diff line number Diff line change
Expand Up @@ -121,6 +121,7 @@ const MySQLConnection = ({
}}
onClickValue={setSelectedInput}
selectedMenu={selectedInput}
menuClassName="!top-14"
/>

{mysql?.mysql_engine_type ===
Expand Down Expand Up @@ -158,6 +159,7 @@ const MySQLConnection = ({
}
onClickValue={setSelectedInput}
selectedMenu={selectedInput}
menuClassName="!top-14"
/>
<FieldTypeInput
data={sharedCredentials}
Expand Down Expand Up @@ -225,6 +227,7 @@ const MySQLConnection = ({
onChange={(value) => handleChange({ sslmode: value })}
onClickValue={setSelectedInput}
selectedMenu={selectedInput}
menuClassName="!top-14"
/>
)}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,10 @@ import {
PostgresqlParametersSpecSslmodeEnum,
SharedCredentialListModel
} from '../../../../api';
import JdbcPropertiesView from '../JdbcProperties';
import FieldTypeInput from '../../../Connection/ConnectionView/FieldTypeInput';
import Select from '../../../Select';
import SectionWrapper from '../../SectionWrapper';
import FieldTypeInput from '../../../Connection/ConnectionView/FieldTypeInput';
import JdbcPropertiesView from '../JdbcProperties';

interface IPostgreSQLConnectionProps {
postgresql?: PostgresqlParametersSpec;
Expand Down Expand Up @@ -105,6 +105,7 @@ const PostgreSQLConnection = ({
className="mb-4"
value={postgresql?.sslmode}
onChange={(value) => handleChange({ sslmode: value })}
menuClassName="!top-14"
/>
<JdbcPropertiesView
properties={postgresql?.properties}
Expand Down
Original file line number Diff line number Diff line change
@@ -1,15 +1,15 @@
import React from 'react';

import SectionWrapper from '../../SectionWrapper';
import {
SharedCredentialListModel,
SqlServerParametersSpec,
SqlServerParametersSpecAuthenticationModeEnum
} from '../../../../api';
import JdbcPropertiesView from '../JdbcProperties';
import FieldTypeInput from '../../../Connection/ConnectionView/FieldTypeInput';
import Checkbox from '../../../Checkbox';
import FieldTypeInput from '../../../Connection/ConnectionView/FieldTypeInput';
import Select from '../../../Select';
import SectionWrapper from '../../SectionWrapper';
import JdbcPropertiesView from '../JdbcProperties';

interface ISqlServerConnectionProps {
sqlserver?: SqlServerParametersSpec;
Expand All @@ -28,14 +28,15 @@ const authenticationModes = [
SqlServerParametersSpecAuthenticationModeEnum.active_directory_password
},
// service principal is not supported yet
// {
// label: 'Active Directory Service Principal',
// value:
// SqlServerParametersSpecAuthenticationModeEnum.active_directory_service_principal
// },
// {
// label: 'Active Directory Service Principal',
// value:
// SqlServerParametersSpecAuthenticationModeEnum.active_directory_service_principal
// },
{
label: 'Active Directory Default',
value: SqlServerParametersSpecAuthenticationModeEnum.active_directory_default
value:
SqlServerParametersSpecAuthenticationModeEnum.active_directory_default
}
];

Expand Down Expand Up @@ -89,6 +90,7 @@ const SqlServerConnection = ({
onChange={(value) => {
handleChange({ authentication_mode: value });
}}
menuClassName="!top-14"
/>

{sqlserver?.authentication_mode !==
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,7 @@ const TrinoConnection = ({
}}
onClickValue={setSelectedInput}
selectedMenu={selectedInput}
menuClassName="!top-14"
/>
{trino?.trino_engine_type ===
TrinoParametersSpecTrinoEngineTypeEnum.trino && (
Expand Down Expand Up @@ -136,6 +137,7 @@ const TrinoConnection = ({
}}
onClickValue={setSelectedInput}
selectedMenu={selectedInput}
menuClassName="!top-14"
/>
{trino?.aws_authentication_mode ===
TrinoParametersSpecAwsAuthenticationModeEnum.iam && (
Expand Down
16 changes: 16 additions & 0 deletions dqops/src/main/frontend/src/components/Select/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,22 @@ const Select = ({
setMenuWidth(ref.current?.offsetWidth || 0);
}, []);

useEffect(() => {
const handleClickOutside = () => {
closeMenu();
};

if (isOpen) {
document.addEventListener('mousedown', handleClickOutside);
} else {
document.removeEventListener('mousedown', handleClickOutside);
}

return () => {
document.removeEventListener('mousedown', handleClickOutside);
};
}, [isOpen, closeMenu]);

return (
<div className={clsx('relative', className)}>
{label && (
Expand Down