Refactor code in smaller files and remove most IDE warnings #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I strongly prefer to keep code together in one file that's closely related, and instead split on what could've been a separate package. It makes it easier to jump back and forth between related definitions. Also, it reduces time spent thinking about what file to put new code in. At some point this becomes unwieldy, but that'd be if the file grows above say 3000 lines of code or so. |
|
Fine, no problem. I'll close this PR then. |
|
Btw, your IDE uses golangci-lint? |
|
As far as I know, it does not. I'm using the default settings of GoLand from JetBrains. |
|
I fixed some issues raised by golangci-lint in 76c8782. I'll enable it in CI once all are fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hope this doesn't take you too much by surprise. Let me know if you don't agree with (parts of) it.
I made an attempt to bring a bit more structure into the code and especially split up the very long
mtc.gofile into multiple. For now, I stored most stuff in the/pkgdirectory, but I would leave it up to you, if you prefer it in the/internalfolder (for now).The changes should not contain any functional changes.