Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

a docker image to be used for creating Terra cloud environment #421

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

SHuang-Broad
Copy link
Collaborator

No description provided.

Copy link
Collaborator

@jonn-smith jonn-smith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great idea. I had one question about including gsutil.

Another question - are there other fundamental packages that are missing? What about things like bwa-mem / bwa-mem2 / minigraph / miniasm?

apt-get -qqy clean && \
rm -rf /tmp/* \
/var/tmp/* \
/var/cache/apt/*
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about other common cloud utilities, such as gsutil? Does the terra base image include that?

FYI, this is how I usually install it so crcmod works and parallel uploads/downloads are fast:

# install gsutil
RUN apt-get --allow-releaseinfo-change update
RUN apt install -y curl git-lfs time datamash
RUN curl https://sdk.cloud.google.com | bash

# Setup crcmodc for gsutil:
RUN apt-get install -y gcc python3-dev python3-setuptools && \
			pip3 uninstall -y crcmod && \
			pip3 install --no-cache-dir -U crcmod

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, you're right. The base image I depend on handles the google cloud stuff.
I don't want to mess with that, other than that line which updates the google cloud cli.

Copy link
Collaborator

@jonn-smith jonn-smith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, sounds good. Feel free to merge.

@SHuang-Broad
Copy link
Collaborator Author

Thanks for the review, Jonn.
The base image I used is now out of date, after talking with the Terra team.
So I'll hold off on merging, and update when they release the much smaller, official base image.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants