[PM-13645] fix seat count to include invited and accepted members

[BTreston]

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-13645

📔 Objective

This PR fixes the seat count to include members that are in invited and accepted statuses.

📸 Screenshots

⏰ Reminders before review

• Contributor guidelines followed
• All formatters and local linters executed and passed
• Written new unit and / or integration tests where applicable
• Protected functional changes with optionality (feature flags)
• Used internationalization (i18n) for all UI strings
• CI builds passed
• Communicated to DevOps any deployment requirements
• Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

• 👍 (:+1:) or similar for great changes
• 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
• ❓ (:question:) for questions
• 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
• 🎨 (:art:) for suggestions / improvements
• ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
• 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
• ⛏ (:pick:) for minor or nitpick changes

[github-actions]

Checkmarx One – Scan Summary & Details – 84d79e2b-f9c4-4e68-b964-9d0cd227332f

New Issues (9)

Checkmarx found the following issues in this Pull Request

Severity	Issue	Source File / Package	Checkmarx Insight
	Angular_Improper_Type_Pipe_Usage	/apps/browser/src/vault/popup/components/vault-v2/vault-list-items-container/vault-list-items-container.component.html: 107	details The value used in hideAutofillButton$ at /apps/browser/src/vault/popup/components/vault-v2/vault-list-items-container/vault-list-items-container.co... Attack Vector
	Angular_Improper_Type_Pipe_Usage	/apps/browser/src/vault/popup/components/vault-v2/vault-v2.component.html: 33	details The value used in loading$ at /apps/browser/src/vault/popup/components/vault-v2/vault-v2.component.html in line 33 may throw an exception with the ... Attack Vector
	Client_Privacy_Violation	/apps/browser/src/vault/popup/components/vault-v2/vault-v2.component.html: 78	details Method vault_v2_component at line 78 of /apps/browser/src/vault/popup/components/vault-v2/vault-v2.component.html sends user information outside th... Attack Vector
	Client_Privacy_Violation	/apps/browser/src/vault/popup/components/vault-v2/vault-v2.component.html: 72	details Method vault_v2_component at line 72 of /apps/browser/src/vault/popup/components/vault-v2/vault-v2.component.html sends user information outside th... Attack Vector
	Client_Privacy_Violation	/apps/browser/src/vault/popup/components/vault-v2/autofill-vault-list-items/autofill-vault-list-items.component.html: 3	details Method autofill_vault_list_items_component at line 3 of /apps/browser/src/vault/popup/components/vault-v2/autofill-vault-list-items/autofill-vault-... Attack Vector
	Client_Privacy_Violation	/apps/browser/src/vault/popup/components/vault-v2/vault-list-items-container/vault-list-items-container.component.html: 91	details Method itemGroup at line 91 of /apps/browser/src/vault/popup/components/vault-v2/vault-list-items-container/vault-list-items-container.component.ht... Attack Vector
	Client_Privacy_Violation	/apps/browser/src/vault/popup/components/vault-v2/vault-list-items-container/vault-list-items-container.component.html: 104	details Method itemGroup at line 104 of /apps/browser/src/vault/popup/components/vault-v2/vault-list-items-container/vault-list-items-container.component.h... Attack Vector
	Client_Privacy_Violation	/apps/browser/src/vault/popup/components/vault-v2/vault-list-items-container/vault-list-items-container.component.ts: 117	details Method at line 117 of /apps/browser/src/vault/popup/components/vault-v2/vault-list-items-container/vault-list-items-container.component.ts sends u... Attack Vector
	Client_Privacy_Violation	/apps/browser/src/vault/popup/components/vault-v2/autofill-vault-list-items/autofill-vault-list-items.component.html: 1	details Method autofill_vault_list_items_component at line 1 of /apps/browser/src/vault/popup/components/vault-v2/autofill-vault-list-items/autofill-vault-... Attack Vector

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 34.29%. Comparing base (d471fe0) to head (bc1ab16).
Report is 12 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines	Patch %	Lines
...omponents/member-dialog/member-dialog.component.ts	0.00%	1 Missing ⚠️
...console/organizations/members/members.component.ts	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #12848      +/-   ##
==========================================
- Coverage   34.29%   34.29%   -0.01%     
==========================================
  Files        2934     2934              
  Lines       90188    90189       +1     
  Branches    16939    16939              
==========================================
  Hits        30930    30930              
- Misses      56794    56795       +1     
  Partials     2464     2464              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[ttalty]

Approved. One thing to think about. Do we need to always use all these params?

[BTreston]

Approved. One thing to think about. Do we need to always use all these params?

Good question, we should probably look into refactoring this into more focused components with params that make sense. I'll make a note of it and make a tech debt ticket to address it at some point.