Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-15506] browser vNextOrganizationService implementation #12844

Conversation

BTreston
Copy link
Contributor

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-15506

📔 Objective

Partial implementation of vNextOrganizationService for the browser client.

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link
Contributor

github-actions bot commented Jan 13, 2025

Logo
Checkmarx One – Scan Summary & Details470c8fac-61db-4659-87cd-2fe6856c1851

Fixed Issues (2)

Great job! The following issues were fixed in this Pull Request

Severity Issue Source File / Package
MEDIUM Client_Privacy_Violation /apps/browser/src/vault/popup/components/vault-v2/attachments/open-attachments/open-attachments.component.ts: 50
MEDIUM Client_Privacy_Violation /apps/browser/src/vault/popup/components/vault-v2/attachments/open-attachments/open-attachments.component.ts: 50

@BTreston BTreston changed the base branch from main to ac/pm-15506-vNextOrganizationService January 13, 2025 19:35
@BTreston BTreston changed the title Ac/pm 15506 browser v next organization service [PM-15506] browser vNextOrganizationService implementation Jan 14, 2025
@BTreston BTreston marked this pull request as ready for review January 14, 2025 20:58
@BTreston BTreston requested review from a team as code owners January 14, 2025 20:58
@BTreston BTreston requested a review from cd-bitwarden January 14, 2025 20:58
Copy link

codecov bot commented Jan 14, 2025

Codecov Report

Attention: Patch coverage is 27.77778% with 39 lines in your changes missing coverage. Please review.

Please upload report for BASE (ac/pm-15506-vNextOrganizationService@6a59af3). Learn more about missing BASE report.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...bout-page/more-from-bitwarden-page-v2.component.ts 0.00% 8 Missing ⚠️
...lt/popup/components/vault/vault-items.component.ts 0.00% 8 Missing ⚠️
...lt/popup/components/vault/current-tab.component.ts 0.00% 7 Missing ⚠️
...t/popup/components/vault/vault-select.component.ts 0.00% 7 Missing ⚠️
...2/item-more-options/item-more-options.component.ts 0.00% 5 Missing ⚠️
...ps/browser/src/services/families-policy.service.ts 78.57% 0 Missing and 3 partials ⚠️
...nts/open-attachments/open-attachments.component.ts 80.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@                           Coverage Diff                           @@
##             ac/pm-15506-vNextOrganizationService   #12844   +/-   ##
=======================================================================
  Coverage                                        ?   33.67%           
=======================================================================
  Files                                           ?     2918           
  Lines                                           ?    91322           
  Branches                                        ?    17265           
=======================================================================
  Hits                                            ?    30751           
  Misses                                          ?    58143           
  Partials                                        ?     2428           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BTreston BTreston merged commit 356be48 into ac/pm-15506-vNextOrganizationService Jan 14, 2025
33 checks passed
@BTreston BTreston deleted the ac/pm-15506-browser-vNextOrganizationService branch January 14, 2025 20:59
BTreston added a commit that referenced this pull request Jan 22, 2025
* [PM-15506] Wire up vNextOrganizationService for libs/common and libs/angular (#12683)

* Wire up vNextOrganizationService in PolicyService

* Wire vNextOrganizationService in SyncService

* wire vNextOrganizationService for EventCollectionService

* wire vNextOrganizationService for KeyConnectorService

* wire up vNextOrganizationService for CipherAuthorizationService

* Wire up vNextOrganizationService in PolicyService

* Wire vNextOrganizationService in SyncService

* wire vNextOrganizationService for EventCollectionService

* wire vNextOrganizationService for KeyConnectorService

* wire up vNextOrganizationService for CipherAuthorizationService

* wire vNextOrganizationService for share.component

* wire vNextOrganizationService for collections.component

* wire vNextOrganizationServcie for add-account-credit-dialog

* wire vNextOrganizationService for vault-filter.service

* fix browser errors for vNextOrganizationService implementation in libs

* fix desktop errors for vNextOrganizationService implementation for libs

* fix linter errors

* fix CLI errors on vNextOrganizationServcie implementations for libs

* [PM-15506] Wire up vNextOrganizationService for web client (#12810)

PR to a feature branch, no need to review until this goes to main.

* implement vNextOrganization service for browser client (#12844)

PR to feature branch, no need for review yet.

* wire vNextOrganizationService for licence and some web router guards

* wire vNextOrganizationService in tests

* remove vNext notation for OrganizationService and related

* Merge branch 'main' into ac/pm-15506-vNextOrganizationService

* fix tsstrict error

* fix test, fix ts strict error
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant