-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PM-16891 Applications at risk dialog #12843
Conversation
New Issues (9)Checkmarx found the following issues in this Pull Request
|
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #12843 +/- ##
==========================================
- Coverage 34.29% 34.27% -0.02%
==========================================
Files 2934 2935 +1
Lines 90194 90229 +35
Branches 16940 16943 +3
==========================================
Hits 30930 30930
- Misses 56800 56835 +35
Partials 2464 2464 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎨Priya requests that in the header the word "Applications" should not be capitalized.
🎨 The text with "These applications have..." should be the body-1 font and black.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-16891
📔 Objective
Clicking on the "Applications at Risk" card, a dialog should render, listing all applications and the count of passwords at risk.
📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes