Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PM-16891 Applications at risk dialog #12843

Merged
merged 11 commits into from
Jan 14, 2025
Merged

Conversation

voommen-livefront
Copy link
Collaborator

@voommen-livefront voommen-livefront commented Jan 13, 2025

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-16891

📔 Objective

Clicking on the "Applications at Risk" card, a dialog should render, listing all applications and the count of passwords at risk.

📸 Screenshots

image

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@voommen-livefront voommen-livefront requested a review from a team as a code owner January 13, 2025 18:54
Copy link
Contributor

github-actions bot commented Jan 13, 2025

Logo
Checkmarx One – Scan Summary & Details191c2d85-f724-4b9b-886d-43b222cc3e20

New Issues (9)

Checkmarx found the following issues in this Pull Request

Severity Issue Source File / Package Checkmarx Insight
MEDIUM Angular_Improper_Type_Pipe_Usage /apps/browser/src/vault/popup/components/vault-v2/vault-list-items-container/vault-list-items-container.component.html: 107
detailsThe value used in hideAutofillButton$ at /apps/browser/src/vault/popup/components/vault-v2/vault-list-items-container/vault-list-items-container.co...
Attack Vector
MEDIUM Angular_Improper_Type_Pipe_Usage /apps/browser/src/vault/popup/components/vault-v2/vault-v2.component.html: 33
detailsThe value used in loading$ at /apps/browser/src/vault/popup/components/vault-v2/vault-v2.component.html in line 33 may throw an exception with the ...
Attack Vector
MEDIUM Client_Privacy_Violation /apps/browser/src/vault/popup/components/vault-v2/vault-v2.component.html: 78
detailsMethod vault_v2_component at line 78 of /apps/browser/src/vault/popup/components/vault-v2/vault-v2.component.html sends user information outside th...
Attack Vector
MEDIUM Client_Privacy_Violation /apps/browser/src/vault/popup/components/vault-v2/vault-v2.component.html: 72
detailsMethod vault_v2_component at line 72 of /apps/browser/src/vault/popup/components/vault-v2/vault-v2.component.html sends user information outside th...
Attack Vector
MEDIUM Client_Privacy_Violation /apps/browser/src/vault/popup/components/vault-v2/autofill-vault-list-items/autofill-vault-list-items.component.html: 3
detailsMethod autofill_vault_list_items_component at line 3 of /apps/browser/src/vault/popup/components/vault-v2/autofill-vault-list-items/autofill-vault-...
Attack Vector
MEDIUM Client_Privacy_Violation /apps/browser/src/vault/popup/components/vault-v2/vault-list-items-container/vault-list-items-container.component.ts: 117
detailsMethod at line 117 of /apps/browser/src/vault/popup/components/vault-v2/vault-list-items-container/vault-list-items-container.component.ts sends u...
Attack Vector
MEDIUM Client_Privacy_Violation /apps/browser/src/vault/popup/components/vault-v2/autofill-vault-list-items/autofill-vault-list-items.component.html: 1
detailsMethod autofill_vault_list_items_component at line 1 of /apps/browser/src/vault/popup/components/vault-v2/autofill-vault-list-items/autofill-vault-...
Attack Vector
MEDIUM Client_Privacy_Violation /apps/browser/src/vault/popup/components/vault-v2/vault-list-items-container/vault-list-items-container.component.html: 104
detailsMethod itemGroup at line 104 of /apps/browser/src/vault/popup/components/vault-v2/vault-list-items-container/vault-list-items-container.component.h...
Attack Vector
MEDIUM Client_Privacy_Violation /apps/browser/src/vault/popup/components/vault-v2/vault-list-items-container/vault-list-items-container.component.html: 91
detailsMethod itemGroup at line 91 of /apps/browser/src/vault/popup/components/vault-v2/vault-list-items-container/vault-list-items-container.component.ht...
Attack Vector

Copy link

codecov bot commented Jan 13, 2025

Codecov Report

Attention: Patch coverage is 0% with 19 lines in your changes missing coverage. Please review.

Project coverage is 34.27%. Comparing base (8717d79) to head (db7507f).
Report is 11 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...-intelligence/org-at-risk-apps-dialog.component.ts 0.00% 9 Missing ⚠️
...-insights/services/risk-insights-report.service.ts 0.00% 7 Missing ⚠️
.../access-intelligence/all-applications.component.ts 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12843      +/-   ##
==========================================
- Coverage   34.29%   34.27%   -0.02%     
==========================================
  Files        2934     2935       +1     
  Lines       90194    90229      +35     
  Branches    16940    16943       +3     
==========================================
  Hits        30930    30930              
- Misses      56800    56835      +35     
  Partials     2464     2464              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@ttalty ttalty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎨Priya requests that in the header the word "Applications" should not be capitalized.

🎨 The text with "These applications have..." should be the body-1 font and black.

@ttalty ttalty merged commit f2b6f05 into main Jan 14, 2025
40 checks passed
@ttalty ttalty deleted the tools/PM-16891/members-at-risk-dialog branch January 14, 2025 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants