Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-16858] - Desktop - Generator modal - Update submit button #12841

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jaasen-livefront
Copy link
Collaborator

๐ŸŽŸ๏ธ Tracking

https://bitwarden.atlassian.net/browse/PM-16858

๐Ÿ“” Objective

This PR addresses the QA feedback and updates the button copy for generate passphrase modal. It also remove a legacy css class to ensure the modern button styling is applied.

๐Ÿ“ธ Screenshots

Passphrase Password Username
Screenshot 2025-01-13 at 10 07 05โ€ฏAM Screenshot 2025-01-13 at 10 06 59โ€ฏAM Screenshot 2025-01-13 at 10 06 52โ€ฏAM

โฐ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

๐Ÿฆฎ Reviewer guidelines

  • ๐Ÿ‘ (:+1:) or similar for great changes
  • ๐Ÿ“ (:memo:) or โ„น๏ธ (:information_source:) for notes or general info
  • โ“ (:question:) for questions
  • ๐Ÿค” (:thinking:) or ๐Ÿ’ญ (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • ๐ŸŽจ (:art:) for suggestions / improvements
  • โŒ (:x:) or โš ๏ธ (:warning:) for more significant problems or concerns needing attention
  • ๐ŸŒฑ (:seedling:) or โ™ป๏ธ (:recycle:) for future improvements or indications of technical debt
  • โ› (:pick:) for minor or nitpick changes

Copy link
Contributor

Logo
Checkmarx One โ€“ Scan Summary & Details โ€“ 3df7dee5-f154-4746-b5e9-7f73b99ef0a6

Great job, no security vulnerabilities found in this Pull Request

Copy link

codecov bot commented Jan 13, 2025

Codecov Report

All modified and coverable lines are covered by tests โœ…

Project coverage is 34.28%. Comparing base (7b11905) to head (b47948d).
Report is 1 commits behind head on main.

โœ… All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #12841   +/-   ##
=======================================
  Coverage   34.27%   34.28%           
=======================================
  Files        2933     2933           
  Lines       90078    90078           
  Branches    16915    16915           
=======================================
+ Hits        30877    30884    +7     
+ Misses      56743    56736    -7     
  Partials     2458     2458           

โ˜” View full report in Codecov by Sentry.
๐Ÿ“ข Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants