Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CL-485] Add small delay for async action loading state #12835

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

vleague2
Copy link
Contributor

@vleague2 vleague2 commented Jan 13, 2025

🎟️ Tracking

CL-485

📔 Objective

This PR adds a small delay to the display of the loading spinner for standalone async actions. This helps minimize the "flash" of the loading spinner for quick-resolving actions that don't need to display a spinner. For example, this will improve the back button experience in the extension.

📸 Screenshots

Extension back button as an example:

Screen.Recording.2025-01-13.at.11.58.04.AM.mov

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link
Contributor

github-actions bot commented Jan 13, 2025

Logo
Checkmarx One – Scan Summary & Details1fc663a0-7782-4826-ae6e-f59e04a362b7

New Issues (3)

Checkmarx found the following issues in this Pull Request

Severity Issue Source File / Package Checkmarx Insight
HIGH CVE-2024-12381 Npm-electron-33.2.1 Vulnerable Package
MEDIUM CVE-2024-11110 Npm-electron-33.2.1 Vulnerable Package
MEDIUM CVE-2024-11117 Npm-electron-33.2.1 Vulnerable Package

Copy link

codecov bot commented Jan 13, 2025

Codecov Report

Attention: Patch coverage is 0% with 24 lines in your changes missing coverage. Please review.

Project coverage is 34.27%. Comparing base (52b6bfe) to head (7c4f725).
Report is 24 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...components/src/async-actions/standalone.stories.ts 0.00% 16 Missing ⚠️
...mponents/src/async-actions/bit-action.directive.ts 0.00% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12835      +/-   ##
==========================================
- Coverage   34.28%   34.27%   -0.02%     
==========================================
  Files        2933     2934       +1     
  Lines       90065    90238     +173     
  Branches    16912    16945      +33     
==========================================
+ Hits        30880    30930      +50     
- Misses      56727    56844     +117     
- Partials     2458     2464       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vleague2 vleague2 marked this pull request as ready for review January 14, 2025 16:49
@vleague2 vleague2 requested a review from a team as a code owner January 14, 2025 16:49
@vleague2
Copy link
Contributor Author

@danielleflinn Curious to hear your thoughts on the delay timing that has been added -- you can play with it in Storybook's async actions stories

Copy link
Member

@danielleflinn danielleflinn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screen recording looks so smooth! 😍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants