-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PM-16985] Fix biometrics not working in firefox or windows #12833
Conversation
New Issues (3)Checkmarx found the following issues in this Pull Request
Fixed Issues (1)Great job! The following issues were fixed in this Pull Request
|
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #12833 +/- ##
==========================================
- Coverage 34.28% 34.27% -0.01%
==========================================
Files 2933 2933
Lines 90081 90103 +22
Branches 16916 16919 +3
==========================================
Hits 30886 30886
- Misses 56737 56759 +22
Partials 2458 2458 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* Fix biometrics not working in firefox or windows * Remove logs * Update badge after biometric unlock * Add removal todo note * Remove debug logging * Fix type warnings * Fix userkey typing in background biometrics service * Simplify types for userkey in foreground-browser-biometrics and runtime.background.ts (cherry picked from commit 8e95029)
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-16985
📔 Objective
Fixes biometrics not working in popup extensions. The biometrics service expected the consumer in the UI code to handle the result - the userkey - and set it to state. However, in the extensions, the UI process gets closed when doing UI depending on the browser - if it is in popup mode. In popout things work fine.
For this reason, we also set the userkey, and the biometrics enabled setting as a side-effect in biometrics background, in order to restore functionality. This will most likely be revisited lated, as it is just a hotfix.
📸 Screenshots
Screen.Recording.2025-01-13.at.18.28.48.mov
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes