Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-16662] Fix annual pricing for billable providers #12657

Merged
merged 4 commits into from
Jan 22, 2025
Merged

Conversation

jonashendrickx
Copy link
Member

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-16662

📔 Objective

  • Fixed label showing 'year' instead of 'month', when the billing cadence was actually annually.
  • Adjusted scopes for fields, methods & properties.

📸 Screenshots

image

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@jonashendrickx jonashendrickx requested a review from a team as a code owner January 2, 2025 16:06
Copy link
Contributor

github-actions bot commented Jan 2, 2025

Logo
Checkmarx One – Scan Summary & Detailsffca0152-3bd4-4428-98f2-4ff6cfddca26

New Issues (18)

Checkmarx found the following issues in this Pull Request

Severity Issue Source File / Package Checkmarx Insight
HIGH CVE-2024-12381 Npm-electron-33.2.1 Vulnerable Package
MEDIUM Angular_Improper_Type_Pipe_Usage /apps/browser/src/autofill/popup/fido2/fido2-use-browser-link-v1.component.html: 1
detailsThe value used in fido2PopoutSessionData$ at /apps/browser/src/autofill/popup/fido2/fido2-use-browser-link-v1.component.html in line 1 may throw an...
Attack Vector
MEDIUM CVE-2024-11110 Npm-electron-33.2.1 Vulnerable Package
MEDIUM CVE-2024-11117 Npm-electron-33.2.1 Vulnerable Package
MEDIUM Client_Privacy_Violation /apps/browser/src/vault/popup/components/vault-v2/vault-list-items-container/vault-list-items-container.component.html: 15
detailsMethod at line 15 of /apps/browser/src/vault/popup/components/vault-v2/vault-list-items-container/vault-list-items-container.component.html sends ...
Attack Vector
MEDIUM Client_Privacy_Violation /apps/browser/src/autofill/popup/settings/autofill-v1.component.ts: 103
detailsMethod AutofillV1Component at line 103 of /apps/browser/src/autofill/popup/settings/autofill-v1.component.ts sends user information outside the app...
Attack Vector
MEDIUM Client_Privacy_Violation /apps/browser/src/vault/popup/components/vault/attachments.component.html: 25
detailsMethod attachments_component at line 25 of /apps/browser/src/vault/popup/components/vault/attachments.component.html sends user information outside...
Attack Vector
MEDIUM Client_Privacy_Violation /apps/browser/src/vault/popup/components/vault/attachments.component.html: 25
detailsMethod attachments_component at line 25 of /apps/browser/src/vault/popup/components/vault/attachments.component.html sends user information outside...
Attack Vector
MEDIUM Client_Privacy_Violation /apps/browser/src/autofill/popup/settings/notifications-v1.component.ts: 32
detailsMethod ngOnInit at line 32 of /apps/browser/src/autofill/popup/settings/notifications-v1.component.ts sends user information outside the applicatio...
Attack Vector
MEDIUM Client_Privacy_Violation /apps/browser/src/autofill/popup/fido2/fido2-cipher-row-v1.component.ts: 12
detailsMethod app_fido2_cipher_row_v1 at line 12 of /apps/browser/src/autofill/popup/fido2/fido2-cipher-row-v1.component.ts sends user information outside...
Attack Vector
MEDIUM Client_Privacy_Violation /apps/browser/src/autofill/popup/fido2/fido2-cipher-row-v1.component.ts: 12
detailsMethod app_fido2_cipher_row_v1 at line 12 of /apps/browser/src/autofill/popup/fido2/fido2-cipher-row-v1.component.ts sends user information outside...
Attack Vector
MEDIUM Client_Privacy_Violation /apps/browser/src/autofill/popup/fido2/fido2-cipher-row-v1.component.ts: 12
detailsMethod app_fido2_cipher_row_v1 at line 12 of /apps/browser/src/autofill/popup/fido2/fido2-cipher-row-v1.component.ts sends user information outside...
Attack Vector
MEDIUM Client_Privacy_Violation /apps/browser/src/vault/popup/components/cipher-row.component.ts: 11
detailsMethod app_cipher_row at line 11 of /apps/browser/src/vault/popup/components/cipher-row.component.ts sends user information outside the application...
Attack Vector
MEDIUM Client_Privacy_Violation /apps/browser/src/vault/popup/components/cipher-row.component.ts: 11
detailsMethod app_cipher_row at line 11 of /apps/browser/src/vault/popup/components/cipher-row.component.ts sends user information outside the application...
Attack Vector
MEDIUM Client_Privacy_Violation /apps/browser/src/autofill/popup/settings/autofill-v1.component.ts: 103
detailsMethod AutofillV1Component at line 103 of /apps/browser/src/autofill/popup/settings/autofill-v1.component.ts sends user information outside the app...
Attack Vector
MEDIUM Client_Privacy_Violation /apps/browser/src/vault/popup/components/vault/password-history.component.html: 18
detailsMethod password_history_component at line 18 of /apps/browser/src/vault/popup/components/vault/password-history.component.html sends user informati...
Attack Vector
LOW Client_DOM_Open_Redirect /apps/browser/src/vault/popup/components/vault/attachments.component.ts: 37
detailsThe potentially tainted value provided by location in /apps/browser/src/vault/popup/components/vault/attachments.component.ts at line 37 is used as...
Attack Vector
LOW Client_DOM_Open_Redirect /apps/browser/src/vault/popup/components/vault/password-history.component.ts: 23
detailsThe potentially tainted value provided by location in /apps/browser/src/vault/popup/components/vault/password-history.component.ts at line 23 is us...
Attack Vector
Fixed Issues (3)

Great job! The following issues were fixed in this Pull Request

Severity Issue Source File / Package
MEDIUM Client_Privacy_Violation /libs/vault/src/components/decryption-failure-dialog/decryption-failure-dialog.component.html: 17
MEDIUM Client_Privacy_Violation /bitwarden_license/bit-web/src/app/tools/access-intelligence/org-at-risk-members-dialog.component.html: 17
LOW Client_JQuery_Deprecated_Symbols /apps/browser/src/background/runtime.background.ts: 94

@jonashendrickx jonashendrickx enabled auto-merge (squash) January 2, 2025 16:41
auto-merge was automatically disabled January 2, 2025 17:17

Pull request was closed

@jonashendrickx jonashendrickx reopened this Jan 3, 2025
Copy link

codecov bot commented Jan 5, 2025

Codecov Report

Attention: Patch coverage is 0% with 9 lines in your changes missing coverage. Please review.

Project coverage is 34.30%. Comparing base (196c1e1) to head (92cb61b).
Report is 216 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...rs/subscription/provider-subscription.component.ts 0.00% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12657      +/-   ##
==========================================
+ Coverage   33.74%   34.30%   +0.55%     
==========================================
  Files        2918     2934      +16     
  Lines       90994    90193     -801     
  Branches    17200    16942     -258     
==========================================
+ Hits        30703    30937     +234     
+ Misses      57891    56792    -1099     
- Partials     2400     2464      +64     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jonashendrickx jonashendrickx added the needs-qa Marks a PR as requiring QA approval label Jan 6, 2025
@github-actions github-actions bot temporarily deployed to Web Vault - EU QA Cloud January 7, 2025 18:02 Inactive
@jonashendrickx jonashendrickx removed the needs-qa Marks a PR as requiring QA approval label Jan 22, 2025
@jonashendrickx jonashendrickx merged commit 0974838 into main Jan 22, 2025
23 of 24 checks passed
@jonashendrickx jonashendrickx deleted the PM-16662 branch January 22, 2025 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants