Telemetry: Emit session_start during startup activities #4981
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rli
reviewed
Oct 18, 2024
Comment on lines
12
to
14
| companion object { | ||
| private var runOnce = AtomicBoolean(false) | ||
| } |
There was a problem hiding this comment.
didnt know that existed thanks
rli
approved these changes
Oct 22, 2024
|
|
||
| class AwsToolkitStartupMetrics : ProjectActivity { | ||
| override suspend fun execute(project: Project) { | ||
| RunOnceUtil.runOnceForApp(taskId) { |
There was a problem hiding this comment.
consider:
Suggested change
| RunOnceUtil.runOnceForApp(taskId) { | |
| RunOnceUtil.runOnceForApp(this::class.qualifiedName) { |
manodnyab
reviewed
Oct 31, 2024
| @@ -195,6 +195,7 @@ | |||
| <statusBarWidgetFactory id="AwsSettingsPanel" implementation="software.aws.toolkits.jetbrains.core.credentials.AwsSettingsPanelInstaller"/> | |||
| <statusBarWidgetFactory id="CawsSpaceProjectInfo" implementation="software.aws.toolkits.jetbrains.services.caws.CawsStatusBarInstaller"/> | |||
|
|
|||
| <postStartupActivity implementation="software.aws.toolkits.jetbrains.services.telemetry.AwsToolkitStartupMetrics" order="first"/> | |||
There was a problem hiding this comment.
I wonder if we should skip the order here? Would it interfere with any other JB specific activities?
Qodana Community for JVMIt seems all right 👌 No new problems were found according to the checks applied 💡 Qodana analysis was run in the pull request mode: only the changed files were checked Contact Qodana teamContact us at [email protected]
|
...community/src/software/aws/toolkits/jetbrains/services/telemetry/AwsToolkitStartupMetrics.kt
Fixed
Show fixed
Hide fixed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
Description
"session_start: this metric is emitted upon starting of the toolkit. This could be because of update, reloads or installation."
Added a new routine to post-startup activities to emit session start before other tasks run.
Checklist
License
I confirm that my contribution is made under the terms of the Apache 2.0 license.