Closed Bug 1889240 Opened 9 months ago Closed 8 months ago

Translate Button Sometimes Overlaps with Reader Mode and Review Checker

Categories

(Fenix :: Translations, defect, P1)

Product:
Fenix
Component:
Translations
Platform:
All
Android
Type:
defect

Tracking

(firefox126 unaffected, firefox127 wontfix, firefox128 fixed)

Status:
RESOLVED FIXED
Milestone:
127 Branch
Tracking Flags:
Tracking Status
firefox126 --- unaffected
firefox127 --- wontfix
firefox128 --- fixed

People

(Reporter: olivia, Assigned: mavduevskiy)

References

Details

(Whiteboard: [fxdroid][foundation][translations:127])

Attachments

(1 file)

Bug 1889240 - Fix toolbar actions overlapping each other
48 bytes, text/x-phabricator-request
Details | Review

STR:

  • Have translations enabled

  • Go to a Wikipedia article in another language that the system language so both the Translations and Reader Mode icon should appear

  • Continually drill down to subsequent Wikipedia article links until the bug appears

    • I clicked links at a fairly quick pace, was able to reproduce consistently x3
    • The bug is the icons overlap and stay overlapped until navigation

  • Generally have to click through very quickly to have this issue.

Some screenshots of the behavior here.

Severity: -- → S2
Priority: -- → P2
Whiteboard: [fxdroid][foundation]
Blocks: android-toolbar-redesign
Severity: S2 → S3

Noticed the overlap is especially pronounced when turning reader mode on and off with the change in bug 1884769. I think the reader mode transition might be causing the overlapping behavior or making it worse.

Bug 1891192 and this one are very related. Bug 1891192 has a good video of the issue.

See Also: → 1891192
See Also: → 1885161
Assignee: nobody → mavduevskiy
Whiteboard: [fxdroid][foundation] → [fxdroid][foundation][translations:127]
See Also: → 1895645

Setting toolbar redesign's Nightly blockers to priority P1.

Priority: P2 → P1

Just encountered this issue on a fresh install:

  1. Opened mozilla.org/fr, and from the translations bottom sheet tapped on the "Learn more" hyperlink.
  2. The SUMO page opened in a new tab.
  3. Swipe from the SUMO tab to the tab from step 1, and observe the overlapped icons.

Reproducible 100%. Tested on today's Nightly 127.0a1 from 5/9, with a Lenovo tab M10 (Android 10).
Not reproducible on Google Pixel 6 (Android 14).

Flags: needinfo?(ohall)

Thanks for testing and finding an easier STR! Mike has a patch proposal to fix this issue and it is finishing review.

Flags: needinfo?(ohall)
Pushed by mavduevskiy@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/4275f8979796 Fix toolbar actions overlapping each other r=android-reviewers,giorga,ohall

https://hg.mozilla.org/mozilla-central/rev/4275f8979796

Status: NEW → RESOLVED
Closed: 8 months ago
status-firefox127: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 127 Branch
Regressions: 1896347

The patch landed in nightly and beta is affected.
:mavduevskiy, is this bug important enough to require an uplift?

  • If yes, please nominate the patch for beta approval. Also, don't forget to request an uplift for the patches in the regression caused by this fix.
  • If no, please set status-firefox127 to wontfix.

For more information, please visit BugBot documentation.

Flags: needinfo?(mavduevskiy)
status-firefox127: affected → wontfix
Flags: needinfo?(mavduevskiy)
See Also: → 1928682
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: