Found in

• Nightly 126.0a1 (2024-03-19)

Affected versions

• Nightly 126.0a1 (2024-03-19)

Affected platforms

• Windows

Preconditions:
Enable pdfjs.enableHighlightEditor - true
pdfjs.enableHighlightFloatingButton - true

Steps to reproduce

1. Open any PDF in Firefox.
2. Highlight any text.
3. Undo the Highlight with Ctrl+Z
4. Disable the Highlight tool.
5. Enable Caret Browsing and click inside.
6. Select Text with Shift + Right arrow.

Expected result

• The Text should be selected and the Highlight Floating button should be displayed

Actual result

• The Tab Crashes.

Regression range
Not a regression.

@Calixte, can you please take a look at this issue ? I think this might be caused by the new Floating button, I can't reproduce this issue if the Highlight Floating button is disabled.

Can you test in a nightly without bug 1860328? So a couple days ago. This could be a regression from that.

Actually I was able to reproduce

Simpler STR:

set pref accessibility.browsewithcaret = true
open https://uwaterloo.ca/onbase/sites/ca.onbase/files/uploads/files/sampleunsecuredpdf.pdf
click on the text, shift plus left or right arrow to select text
repeat until crash

https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=7e490d41e79e01a4241addf807d9c8a6a6e1d712&tochange=d3946837037d31a7b6f83b1977e57c4ea384c904

:sefeng, since you are the author of the regressor, bug 1860328, could you take a look?

For more information, please visit BugBot documentation.

Given that this is also reproducible without highlighting, we can say that 124 is affected too (first version where we support caret browsing in PDFs).

The regressing bug landed in 126.

The bug is marked as blocking firefox126 (nightly). However, the bug still isn't assigned.

:bhood, could you please find an assignee for this tracked bug? Given that it is a regression and we know the cause, we could also simply backout the regressor. If you disagree with the tracking decision, please talk with the release managers.

For more information, please visit BugBot documentation.

I know Sean and Emilio are looking into this, assigning to one of them, feel free to re-assign.

Can you check if this is fixed once bug 1886506 lands and sticks?

(I couldn't repro this one)

Clearing my NI given we are waiting to see if bug 1886506 fixes this

(In reply to Emilio Cobos Álvarez (:emilio) from comment #8)

Can you check if this is fixed once bug 1886506 lands and sticks?

Rares are you still able to repro this in the latest nightly builds?

I was able to reproduce this issue in our latest Nightly 126.0a1 (2024-03-25) ID 20240325214523

I tested and for me this is fixed by bug 1887552, which just landed, I don't think it's made it into a nightly yet.

Can you re-test when you get a chance with the next nightly? Thanks.

This is Verified as fixed in our latest Nightly build 126.0a1 (2024-03-28).

Can someone update the tracking flags to fixed? or should we mark them as Verified directly ?

Updating the main status flag for this.