Investigate the use of column 0 in 1-origin column
Categories
(Core :: JavaScript Engine, task, P3)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox121 | --- | fixed |
People
(Reporter: arai, Assigned: arai)
References
(Blocks 1 open bug)
Details
Attachments
(4 files)
Column number 0 is used as initial value or some kind of default value for 1-origin column number in some places.
Unless there's special reason, it's better using column number 1 instead.
If there's special reason, it's better adding the comment to js/public/ColumnNumber.h file which is going to be added by bug 1847469.
|
Assignee | |
Comment 1•1 year ago
|
||
https://treeherder.mozilla.org/jobs?repo=try&revision=02b44056607d7c92321362bfc537fd395af26d61
looks like all usage can be rewritten to use column 1.
|
|
Assignee | |
Comment 2•1 year ago
|
||
Depends on D192567
|
|
Assignee | |
Comment 3•1 year ago
|
||
Depends on D192778
|
|
Assignee | |
Comment 4•1 year ago
|
||
Depends on D192779
|
|
Assignee | |
Comment 5•1 year ago
|
||
Depends on D192780
|
||
Comment 7•1 year ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/c9209de1effc
https://hg.mozilla.org/mozilla-central/rev/ec2d440c42db
https://hg.mozilla.org/mozilla-central/rev/3b711b616b8d
https://hg.mozilla.org/mozilla-central/rev/dbf901159b35
Description
•