Open Bug 1350213 Opened 8 years ago Updated 2 years ago

The Filter JSON search box does not work

Categories

(DevTools :: Netmonitor, defect, P3)

52 Branch
defect

Tracking

(firefox-esr45 unaffected, firefox52 wontfix, firefox-esr52 affected, firefox53 unaffected, firefox54 unaffected)

REOPENED
Tracking Status
firefox-esr45 --- unaffected
firefox52 --- wontfix
firefox-esr52 --- affected
firefox53 --- unaffected
firefox54 --- unaffected

People

(Reporter: u570177, Unassigned)

References

Details

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:52.0) Gecko/20100101 Firefox/52.0 Build ID: 20170317213448 Steps to reproduce: open develeoper tools click network select any JSON request show JSON values click to search box and type search text Actual results: nothing, filter/search does not work Expected results: JSON viewer shows filtered values
From the browser console: > TypeError: variable._nameString is undefined[Learn More] VariablesView.jsm:1926:11 That's this code: > _performSearch: function (aLowerCaseQuery) { > for (let [, variable] of this._store) { > let currentObject = variable; > let lowerCaseName = variable._nameString.toLowerCase(); This is a regression from bug 996691 and fixed in Firefox 53 and newer (currently on beta) - no idea in which bug it got fixed, it's not set as blocking bug 996691.
Blocks: 996691
Status: UNCONFIRMED → NEW
Component: Untriaged → Developer Tools: Netmonitor
Ever confirmed: true
Fixed as a side-effect of bug 1317651, but probably the underlying problem is still there.
OK, I think _performSearch should be moved from Scope.prototype to the subclass Variable.prototype, and in _doSearch always use > // Retrieve the main Scope in which we add attributes > let scope = this._store[0]._store.get(undefined); (currently it's only used in the conditional)
Too late for firefox 52, mass-wontfix.
There several refactoring patches has landed recently (a couple months ago) and this issue could be fixed in bug 1317650. Let's close this.
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → INVALID
Hi. Its worked, but is not usable. The filter is applied to all json, include data in objects. When I want to check values, I can filter object, but cannot check values inside it.
Status: RESOLVED → REOPENED
Resolution: INVALID → ---
(In reply to Tomáš Kučera [tomi] from comment #6) > Hi. Its worked, but is not usable. The filter is applied to all json, > include data in objects. I'm not sure if this is undesirable. > When I want to check values, I can filter object, > but cannot check values inside it. What do you exactly mean with "check"? Anyways, this bug was about a problem introduced by bug 996691, and fixed as a side effect of bug 1317651. Your problem seems something different. Consider filing a new bug.
Check means "invisible" values. Filter is applied throw all names. If I filter object name, values inside object are invisible. If I cancel filter, object is lost.
(In reply to Tomáš Kučera [tomi] from comment #8) > Check means "invisible" values. Filter is applied throw all names. If I > filter object name, values inside object are invisible. If I cancel filter, > object is lost. OK, now I understand. Note that not filtering out non-matched descendants of matched items would make filter useless in case the root matches but you are interested in some inner item. Anyways, your problem is completely different than what was reported here. Please file a new bug.
I think is not completely new. It is the chain of one trouble. Before 52, it was completely OK.
Product: Firefox → DevTools
Severity: normal → S3
You need to log in before you can comment on or make changes to this bug.