Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix writing to an IO with no external_encoding #2753

Merged
merged 1 commit into from
Jan 4, 2023

Conversation

larskanis
Copy link
Member

A file-IO has no external_encoding by default, so that rb_to_encoding() fails with a TypeError.

This regression was introduces in commit 2e260f5.

Fixes #2752

A file-IO has no external_encoding by default, so that rb_to_encoding() fails with a TypeError.

This regression was introduces in commit 2e260f5.

Fixes sparklemotion#2752

Co-authored-by: Mike Dalessio <[email protected]>
@flavorjones flavorjones merged commit b57c926 into sparklemotion:main Jan 4, 2023
@flavorjones
Copy link
Member

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug] native_write_to: no implicit conversion of nil into String
2 participants