Page MenuHomePhabricator

ChartsComponent
ActivePublic

Milestones

Members (8)

Watchers (5)

Recent Activity

Thu, Dec 19

gerritbot added a comment to T374661: Charts are not compatible with Parsoid - show as raw SVG.

Change #1105740 merged by jenkins-bot:

[mediawiki/services/parsoid@master] Turn on Parsoid Fragment Support v2 for RT testing

https://gerrit.wikimedia.org/r/1105740

Thu, Dec 19, 9:49 PM · Patch-For-Review, MW-1.44-notes (1.44.0-wmf.4; 2024-11-19), Wikipedia-iOS-App-Backlog, Wikipedia-Android-App-Backlog, OKR-Work, Content-Transform-Team-WIP, Parsoid (Tracking), Charts
gerritbot added a comment to T374661: Charts are not compatible with Parsoid - show as raw SVG.

Change #1105740 had a related patch set uploaded (by Subramanya Sastry; author: Subramanya Sastry):

[mediawiki/services/parsoid@master] Turn on Parsoid Fragment Support v2 for RT testing

https://gerrit.wikimedia.org/r/1105740

Thu, Dec 19, 3:31 PM · Patch-For-Review, MW-1.44-notes (1.44.0-wmf.4; 2024-11-19), Wikipedia-iOS-App-Backlog, Wikipedia-Android-App-Backlog, OKR-Work, Content-Transform-Team-WIP, Parsoid (Tracking), Charts

Wed, Dec 18

Ixocactus added a watcher for Charts: Ixocactus.
Wed, Dec 18, 12:47 AM

Mon, Dec 16

Catrope closed T382040: Type inference on service doesn't match client rendered version as Resolved.
Mon, Dec 16, 9:34 PM · Charts
Catrope set the point value for T381611: Run sanitization on data attribute before rendering via echarts to 3.
Mon, Dec 16, 9:28 PM · Charts (Sprint 13), Security
Catrope set the point value for T382038: JSs error thrown in older Safari browsers to 1.
Mon, Dec 16, 9:26 PM · Charts (Sprint 13), Browser-Support-Apple-Safari
Catrope moved T375237: [Timebox/Spike] Limit number of data points in chart types from Sprint 13 to Up Next on the Charts board.
Mon, Dec 16, 9:20 PM · Charts
Catrope moved T375409: Explore and define available MVP tooltip and emphasis features from Sprint 13 to Up Next on the Charts board.
Mon, Dec 16, 9:20 PM · Charts, Design

Fri, Dec 13

aude claimed T382040: Type inference on service doesn't match client rendered version.
Fri, Dec 13, 10:22 PM · Charts
aude added a comment to T382040: Type inference on service doesn't match client rendered version.

I think this was fixed in https://gitlab.wikimedia.org/repos/mediawiki/services/chart-renderer/-/merge_requests/58

Fri, Dec 13, 10:22 PM · Charts
Ryasmeen added a comment to T382176: X- axis label can be unnoticeable with long numbers as units along the axis.

Actually, it still looks the same way when I changed the numbers to be higher:

Screenshot 2024-12-13 at 11.55.46 AM.png (1×3 px, 403 KB)

Fri, Dec 13, 8:00 PM · Charts
Ryasmeen updated the task description for T382176: X- axis label can be unnoticeable with long numbers as units along the axis.
Fri, Dec 13, 7:58 PM · Charts
Ryasmeen added a comment to T382176: X- axis label can be unnoticeable with long numbers as units along the axis.

This was probably be a duplicate of T381218. It looks better now:

Screenshot 2024-12-13 at 11.32.15 AM.png (1×3 px, 369 KB)

Fri, Dec 13, 7:33 PM · Charts
Ryasmeen created T382176: X- axis label can be unnoticeable with long numbers as units along the axis.
Fri, Dec 13, 7:30 PM · Charts
mmartorana added a comment to T381611: Run sanitization on data attribute before rendering via echarts.

Hey @Jdlrobson - I suggest using using libraries like DOMPurify (or he) for this, as they are well-maintained and widely used for handling potential security risks like these.

Fri, Dec 13, 5:43 PM · Charts (Sprint 13), Security
tchin added a comment to T382100: Port chart-renderer service from service-runner to service-utils.

Glad to see this happening! If you have anything you want to upstream to service-utils please be my guest.
We also have a couple patches in the works. This one with help from Santhosh from the language team for a better metrics interface, and this one with help from Chris from SRE for OpenTelemetry support. I probably wouldn't wait on the OTel support since it requires security review though.

Fri, Dec 13, 5:45 AM · Technical-Debt, Charts

Thu, Dec 12

Jdforrester-WMF updated subscribers of T382100: Port chart-renderer service from service-runner to service-utils.

I think T360924 was meant only for Data Engineer's services, but good to see this happening.

Thu, Dec 12, 9:56 PM · Technical-Debt, Charts
Catrope added a parent task for T382100: Port chart-renderer service from service-runner to service-utils: T360924: Replace service runner with a simplified library to better support metrics and debugging: service-utils.
Thu, Dec 12, 9:49 PM · Technical-Debt, Charts
Catrope created T382100: Port chart-renderer service from service-runner to service-utils.
Thu, Dec 12, 9:49 PM · Technical-Debt, Charts
CCiufo-WMF added a subtask for T373354: Support selecting specific series from a dataset in chart definitions: T382011: [Spike] Support different views on data (data dissection).
Thu, Dec 12, 7:21 PM · Charts
CCiufo-WMF added a parent task for T382011: [Spike] Support different views on data (data dissection): T373354: Support selecting specific series from a dataset in chart definitions.
Thu, Dec 12, 7:21 PM · Charts
CCiufo-WMF changed the subtype of T382011: [Spike] Support different views on data (data dissection) from "Task" to "Spike".
Thu, Dec 12, 7:21 PM · Charts
Jdlrobson moved T380218: First draft an SLO for Charts from Sprint 13 to Backlog on the Charts board.
Thu, Dec 12, 7:17 PM · Charts
Jdlrobson placed T381768: Do not blur non-JS version of chart while loading up for grabs.
Thu, Dec 12, 7:15 PM · Charts
CCiufo-WMF renamed T382011: [Spike] Support different views on data (data dissection) from Support different views on data (data dissection) to [Spike] Support different views on data (data dissection).
Thu, Dec 12, 7:14 PM · Charts
CCiufo-WMF added a comment to T382012: Deploy Charts on meta wiki.

I think we can schedule this for early in the new year

Thu, Dec 12, 7:12 PM · Wikimedia-Site-requests, Charts
Jdlrobson moved T382023: [SPIKE] Experimental metadata key for categories in JsonConfig documents from Backlog to Up Next on the Charts board.
Thu, Dec 12, 7:12 PM · Charts, Commons-Datasets
Jdlrobson moved T379390: [placeholder] Develop a list of key areas of Charts to unit test from Backlog to Up Next on the Charts board.
Thu, Dec 12, 7:12 PM · Charts (Sprint 13)
Jdlrobson moved T381612: [Spike] Explore rendering chart into document fragment before adding to page from Backlog to Up Next on the Charts board.
Thu, Dec 12, 7:12 PM · Spike, Security, Charts
Jdlrobson moved T380652: Implement an input sanitization layer before data processing / validation in the chart-renderer service from Backlog to Up Next on the Charts board.
Thu, Dec 12, 7:12 PM · Security, Charts
Bugreporter added a comment to T382038: JSs error thrown in older Safari browsers.

See also: T300912: Add a polyfill for IntersectionObserver to ResourceLoader

Thu, Dec 12, 1:25 AM · Charts (Sprint 13), Browser-Support-Apple-Safari
Bugreporter added a comment to T382038: JSs error thrown in older Safari browsers.

Per caniuse IntersectionObserver is added in Safari 12.1 and iOS 12.2 and current grade A is Safari 11.1 and iOS 11.3.

Thu, Dec 12, 1:16 AM · Charts (Sprint 13), Browser-Support-Apple-Safari
Jdlrobson updated the task description for T382042: Remove code duplication relating to type inference.
Thu, Dec 12, 12:59 AM · Charts
Jdlrobson moved T382011: [Spike] Support different views on data (data dissection) from Backlog to Up Next on the Charts board.
Thu, Dec 12, 12:58 AM · Charts
Jdlrobson triaged T382039: chart-renderer services update as High priority.
Thu, Dec 12, 12:58 AM · Charts (Sprint 13)
Jdlrobson moved T382042: Remove code duplication relating to type inference from Backlog to Up Next on the Charts board.
Thu, Dec 12, 12:58 AM · Charts
Jdlrobson triaged T382042: Remove code duplication relating to type inference as Medium priority.
Thu, Dec 12, 12:58 AM · Charts
Jdlrobson created T382042: Remove code duplication relating to type inference.
Thu, Dec 12, 12:58 AM · Charts
Jdlrobson placed T374065: Document all the technicals decisions we've made so far in the codebase up for grabs.
Thu, Dec 12, 12:37 AM · Epic, Charts
Jdlrobson triaged T382040: Type inference on service doesn't match client rendered version as Medium priority.
Thu, Dec 12, 12:37 AM · Charts
Jdlrobson created T382040: Type inference on service doesn't match client rendered version.
Thu, Dec 12, 12:37 AM · Charts
bvibber created T382039: chart-renderer services update.
Thu, Dec 12, 12:29 AM · Charts (Sprint 13)
Jdlrobson triaged T382038: JSs error thrown in older Safari browsers as High priority.
Thu, Dec 12, 12:22 AM · Charts (Sprint 13), Browser-Support-Apple-Safari
Jdlrobson created T382038: JSs error thrown in older Safari browsers.
Thu, Dec 12, 12:22 AM · Charts (Sprint 13), Browser-Support-Apple-Safari

Wed, Dec 11

Jdlrobson placed T374501: Document the syntax of a chart up for grabs.
Wed, Dec 11, 9:11 PM · Charts
Jdlrobson placed T381350: Determine appropriate font for charts up for grabs.
Wed, Dec 11, 9:11 PM · Charts
Jdlrobson triaged T382023: [SPIKE] Experimental metadata key for categories in JsonConfig documents as Medium priority.
Wed, Dec 11, 9:09 PM · Charts, Commons-Datasets
Jdlrobson triaged T382012: Deploy Charts on meta wiki as Medium priority.
Wed, Dec 11, 9:09 PM · Wikimedia-Site-requests, Charts
Jdlrobson triaged T382011: [Spike] Support different views on data (data dissection) as Medium priority.
Wed, Dec 11, 9:09 PM · Charts
Jdlrobson triaged T381920: [spike] iframe isolation defense in depth for Charts as Medium priority.
Wed, Dec 11, 9:09 PM · Charts