[Task] Remove calls to getIsRawMode() in Wikibase, and calls to setRawMode() in tests
Closed, ResolvedPublic1 Estimated Story Points
Actions

Assigned To

Authored By

	aude
	Apr 6 2015, 2:31 PM

Description

this blocks work on the core api code and might not be trivial.

Details

Subject	Repo	Branch	Lines +/-
Remove final use of setRawMode in Wikibase	mediawiki/extensions/Wikibase	master	+0 -0
API BREAKING CHANGE - Remove rawMode use	mediawiki/extensions/Wikibase	master	+617 -870
APIPOKE - Return for-language key for non raw fallbacks	mediawiki/extensions/Wikibase	master	+16 -1

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Resolved	daniel	T91073 Update Wikidata for ApiResult rewrite
Resolved	Anomie	T96596 Add wfDeprecated() to deprecated ApiResult methods
Invalid	None	T109969 Wikidata breaking API changes (tracking)
Resolved	jayvdb	T110559 Make sure that Pywikibot still works with new api data output format
Resolved	Addshore	T95168 [Task] Remove calls to getIsRawMode() in Wikibase, and calls to setRawMode() in tests

Event Timeline

aude created this task.Apr 6 2015, 2:31 PM

aude raised the priority of this task from to Needs Triage.

aude updated the task description. (Show Details)

aude added a project: MediaWiki-extensions-WikibaseRepository.

aude subscribed.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 6 2015, 2:31 PM

aude added a project: Wikidata.Apr 6 2015, 2:32 PM

aude set Security to None.

aude added a parent task: T91073: Update Wikidata for ApiResult rewrite.

aude mentioned this in T92970: Replace ApiResult::setRawMode use in EntityDataSerializationService.

Anomie subscribed.Apr 6 2015, 3:54 PM

• ksmith subscribed.Apr 6 2015, 4:18 PM

Anomie added a parent task: T96596: Add wfDeprecated() to deprecated ApiResult methods.Apr 20 2015, 6:37 PM

aude triaged this task as High priority.Apr 23 2015, 12:33 PM

aude updated the task description. (Show Details)

JanZerebecki moved this task from incoming to ready to go on the Wikidata board.May 16 2015, 10:38 PM

Addshore renamed this task from Remove calls to getIsRawMode() in ResultBuilder and GetEntities, and calls to setRawMode() in tests to Remove calls to getIsRawMode() in Wikibase, and calls to setRawMode() in tests.Jul 9 2015, 3:52 PM

• ksmith unsubscribed.Jul 9 2015, 4:56 PM

I am looking at this now, bit of re factoring to do first though

All of the re factoring to make this easier is now done.
Now just to make a few API breaks and pokes in order to be able to totally remove our usage of getIsRawMode etc.

Change 227667 had a related patch set uploaded (by Addshore):
APIPOKE - Return for-language key for non raw fallbacks

https://gerrit.wikimedia.org/r/227667

gerritbot added a project: Patch-For-Review.Jul 29 2015, 9:44 AM

JanZerebecki added a project: Wikidata-Sprint-2015-06-30.Jul 31 2015, 12:17 AM

JanZerebecki moved this task from Backlog to Doing on the Wikidata-Sprint-2015-06-30 board.

Tobi_WMDE_SW edited a custom field.Aug 5 2015, 9:05 AM

Change 227667 merged by jenkins-bot:
APIPOKE - Return for-language key for non raw fallbacks

https://gerrit.wikimedia.org/r/227667

Diffusion mentioned this in rMEXT2c5d05725680: Updated mediawiki/extensions Project: mediawiki/extensions/Wikibase….Aug 5 2015, 10:22 AM

Addshore mentioned this in rEWBAf93df1c25589: APIPOKE - Return for-language key for non raw fallbacks.Aug 5 2015, 10:22 AM

Seems like ResultBuilder.php is still using getIsRawMode quite a bit. ApiHelperFactoryTest.php mocks that method (needlessly?). ApiXmlFormatTest.php uses setRawMode().

aude renamed this task from Remove calls to getIsRawMode() in Wikibase, and calls to setRawMode() in tests to [Task] Remove calls to getIsRawMode() in Wikibase, and calls to setRawMode() in tests.Aug 13 2015, 1:39 PM

Basically this will all come down to a breaking change to remove the uses.
But we will probably also have to poke core slightly (i'll explain why when I get back to this)