Modernize protection log to use LogFormatter & have it decoupled from IRC text
Closed, ResolvedPublic
Actions

Description

See comments in Change-Id: Ifeec00fc98c7912b6e16b6f07d1fdc26ab4e4fb5

Currently protection log entries are stored in plain text which is also used as the IRC line, making it hard to be i18n'ed. It could be nice to just store the original restriction array, use the new LogFormatter architecture to format it on display, and have it decoupled from IRC text, so it can be correctly translated without breaking existing bots.

Details

Reference: bz45988

Subject	Repo	Branch	Lines +/-
Migrate protect log to new log system	mediawiki/core	master	+560 -71
Migrate move protect log to new log system	mediawiki/core	master	+160 -14
Migrate protect log to new log system	mediawiki/core	master	+181 -77

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Resolved	Umherirrender	T26156 Messages of log entries should support GENDER
Resolved	None	T23716 Log entries assume sentence starts with username
Open	None	T26620 Log entries are difficult to localize; convert old style logs to the new code
Resolved	Umherirrender	T47988 Modernize protection log to use LogFormatter & have it decoupled from IRC text

Event Timeline

• bzimport raised the priority of this task from to Medium.Nov 22 2014, 1:36 AM

• bzimport added projects: MediaWiki-Logevents, I18n.

• bzimport set Reference to bz45988.

• bzimport added a subscriber: Unknown Object (MLST).

liangent created this task.Mar 11 2013, 3:19 PM

Change 152156 had a related patch set uploaded (by Umherirrender):
Migrate protect log to new log system

https://gerrit.wikimedia.org/r/152156

Patch-For-Review

Umherirrender claimed this task.Feb 22 2015, 9:19 AM

Change 152156 abandoned by Umherirrender:
Migrate protect log to new log system

Reason:
Old patch, no longer support from my side

Feel free to upload or modify in an own patch set.

https://gerrit.wikimedia.org/r/152156

Umherirrender removed Umherirrender as the assignee of this task.Apr 7 2015, 9:05 PM

Umherirrender removed a project: Patch-For-Review.

Umherirrender set Security to None.

Krenair subscribed.Aug 18 2015, 4:04 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 18 2015, 4:04 AM

Change 223440 had a related patch set uploaded (by Alex Monk):
Migrate move protect log to new log system

https://gerrit.wikimedia.org/r/223440

gerritbot added a project: Patch-For-Review.Aug 18 2015, 10:20 PM

Change 223440 merged by jenkins-bot:
Migrate move protect log to new log system

https://gerrit.wikimedia.org/r/223440

Krenair mentioned this in rMW3964b4cc052c: Migrate move protect log to new log system.Aug 18 2015, 11:17 PM

Krenair removed a project: Patch-For-Review.Aug 18 2015, 11:22 PM

• Forrestbot added projects: MW-1.26-release, WMF-deploy-2015-08-25_(1.26wmf20).Aug 19 2015, 7:02 AM

Change 233166 had a related patch set uploaded (by Umherirrender):
[WIP] Migrate protect log to new log system

https://gerrit.wikimedia.org/r/233166

gerritbot added a project: Patch-For-Review.Aug 22 2015, 9:16 PM

Change 233166 merged by jenkins-bot:
Migrate protect log to new log system

https://gerrit.wikimedia.org/r/233166

siebrand mentioned this in rMWd6961552b39f: Migrate protect log to new log system.Sep 25 2015, 3:31 PM

Umherirrender closed this task as Resolved.Sep 25 2015, 3:33 PM

Umherirrender claimed this task.

Umherirrender removed a subscriber: • wikibugs-l-list.

ReleaseTaggerBot added projects: MW-1.27-release (WMF-deploy-2015-10-06_(1.27.0-wmf.2)), MW-1.27-release.Sep 29 2015, 9:18 PM

greg edited projects, added MW-1.27-release-notes; removed MW-1.27-release.Sep 29 2015, 10:28 PM

Jdforrester-WMF edited projects, added MW-1.27-release (WMF-deploy-2015-09-29_(1.27.0-wmf.1)); removed MW-1.27-release (WMF-deploy-2015-10-06_(1.27.0-wmf.2)).Sep 30 2015, 12:49 AM

matej_suchanek updated the task description. (Show Details)Oct 3 2015, 11:29 AM

matej_suchanek removed a project: Patch-For-Review.

matej_suchanek removed a subscriber: gerritbot.

Please mention this on Tech News as this has a quite visible change. With this change, timestamps are now shown in user's timezone, previously it was the actual UTC time at which the log was inserted.

Should probably be in release notes too?

Glaisher added a subscriber: Umherirrender.Oct 9 2015, 3:32 PM

Johan moved this task from To Triage to Announce in next Tech/News on the User-notice board.Oct 14 2015, 3:00 PM

Johan moved this task from Announce in next Tech/News to In current Tech/News draft on the User-notice board.Oct 16 2015, 6:22 PM

• Quiddity moved this task from In current Tech/News draft to Already announced/Archive on the User-notice board.Oct 22 2015, 9:17 PM

Umherirrender mentioned this in T40116: Log message for "protect" action should contain performer name.Nov 10 2015, 7:21 PM

Umherirrender mentioned this in T17736: Show expiry time only once in Protection log, unless both move&edit protection set and expiry at different times.Nov 10 2015, 7:29 PM

Umherirrender mentioned this in T17897: Break down protection summary in log_params (machine-readable, timezone-friendly, localizable expires date/timestamp).Nov 10 2015, 7:39 PM

Umherirrender mentioned this in T23127: Protection log time/expiry uses UTC.

Umherirrender mentioned this in T119041: Protect log should show expiry in interface language.Nov 20 2015, 6:09 PM

Ladsgroup edited projects, added User-notice-archive; removed User-notice.Aug 13 2022, 1:54 PM