Page MenuHomePhabricator
Create Task
Maniphest T372193

FlaggedRevs CI is broken
Closed, ResolvedPublic
Actions

Description

https://gerrit.wikimedia.org/r/c/mediawiki/extensions/FlaggedRevs/+/1061135

57 x ParserOutput::addJsConfigVars was deprecated in MediaWiki 1.38 . Example:

04:03:08 57) MediaWiki\Extension\DiscussionTools\Tests\CommentFormatterTest::testAddDiscussionToolsInternal with data set #56 ('Heading with inline styles (parsoid)', 'Talk:Heading_with_styles', 'cases/heading-style-parsoid/h...d.html', 'cases/heading-style-parsoid/h...y.html', '../data/enwiki-config.json', '../data/enwiki-data.json', false, false)
04:03:08 Use of MediaWiki\Parser\ParserOutput::addJsConfigVars was deprecated in MediaWiki 1.38. [Called from MediaWiki\Extension\DiscussionTools\CommentFormatter::addDiscussionToolsInternal in /workspace/src/extensions/DiscussionTools/includes/CommentFormatter.php at line 420]

Details

SubjectRepoBranchLines +/-
CommentFormatter: Switch from deprecated addJsConfigVars to new setJsConfigVarmediawiki/extensions/DiscussionToolsmaster+1 -1
FlaggablePageView: Switch from deprecated addJsConfigVars to new setJsConfigVarmediawiki/extensions/FlaggedRevsmaster+1 -1
Customize query in gerrit

Event Timeline

Novem_Linguae created this task.Aug 10 2024, 11:26 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 10 2024, 11:26 AM
Jdforrester-WMF subscribed.Aug 10 2024, 11:37 AM

Bah. One second.

gerritbot added a comment.Aug 10 2024, 11:39 AM

Change #1061139 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/extensions/FlaggedRevs@master] FlaggablePageView: Switch from deprecated addJsConfigVars to new setJsConfigVar

https://gerrit.wikimedia.org/r/1061139

gerritbot added a project: Patch-For-Review.Aug 10 2024, 11:39 AM
Jdforrester-WMF claimed this task.Aug 10 2024, 11:40 AM
gerritbot added a comment.Aug 10 2024, 11:50 AM

Change #1061139 abandoned by Jforrester:

[mediawiki/extensions/FlaggedRevs@master] FlaggablePageView: Switch from deprecated addJsConfigVars to new setJsConfigVar

Reason:

Oops, wrong repo, this was right.

https://gerrit.wikimedia.org/r/1061139

gerritbot added a comment.Aug 10 2024, 11:52 AM

Change #1061140 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/extensions/DiscussionTools@master] CommentFormatter: Switch from deprecated addJsConfigVars to new setJsConfigVar

https://gerrit.wikimedia.org/r/1061140

gerritbot added a comment.Aug 10 2024, 12:50 PM

Change #1061140 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@master] CommentFormatter: Switch from deprecated addJsConfigVars to new setJsConfigVar

https://gerrit.wikimedia.org/r/1061140

ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.18; 2024-08-13).Aug 10 2024, 1:00 PM
Ladsgroup closed this task as Resolved.Aug 10 2024, 1:11 PM
Maintenance_bot removed a project: Patch-For-Review.Aug 10 2024, 1:31 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits