Page MenuHomePhabricator
Create Task
Maniphest T372054

Unclosed #contentSub tag causes pages to be rendered incorrectly
Closed, ResolvedPublicBUG REPORT
Actions

Description

Steps to replicate the issue (include links if applicable):

Screenshot of the DOM tree:

image.png (402×1 px, 62 KB)

What happens?:
This causes the entire page content to be smaller.

For the main page, it caused it to not render at all due to a rule for hiding #contentSub. First reported on Russian Wikipedia forum: https://ru.wikipedia.org/wiki/Википедия:Форум/Общий#Заглавная_страница

Screenshot of the page footer with the bug present:

image.png (940×1 px, 256 KB)

What should have happened instead?:
#contentSub should be properly closed. This might be related to some recent changes in FlaggedRevs extension (in T191156: Convert FlaggedRevisions to Codex). It should be fixed ASAP given that this probably would be affecting more and more pages for anonymous users.

Currently I deployed a hotfix for Main Page use case: https://ru.wikipedia.org/?diff=139486499

Details

SubjectRepoBranchLines +/-
Add missing close tags to #contentSub messagemediawiki/extensions/FlaggedRevsmaster+2 -4
Add missing close tags to #contentSub messagemediawiki/extensions/FlaggedRevswmf/1.43.0-wmf.17+2 -4
Customize query in gerrit

Related Objects
Search...

Event Timeline

stjn created this task.Aug 8 2024, 1:02 PM
Restricted Application added a subscriber: Base. · View Herald TranscriptAug 8 2024, 1:02 PM
stjn triaged this task as Unbreak Now! priority.Aug 8 2024, 1:04 PM

Given that this visual bug already caused the main page to not show and causes problems on all pages, raising priority.

stjn updated the task description. (Show Details)Aug 8 2024, 1:05 PM
stjn added projects: MediaWiki-User-Interface, Vector (legacy skin).
stjn updated the task description. (Show Details)
stjn updated the task description. (Show Details)Aug 8 2024, 1:09 PM
stjn updated the task description. (Show Details)
Isochrone subscribed.Aug 8 2024, 1:15 PM
stjn added subscribers: Dogu, Ladsgroup.Aug 8 2024, 1:15 PM

@Dogu @Ladsgroup since people are reporting this also being the case in enWP on FlaggedRevs-enabled pages, tagging you both here for quicker response:

Example: https://en.wikipedia.org/wiki/Martine_Croxall

DOM tree screenshot:

image.png (389×1 px, 58 KB)

stjn removed a project: Vector (legacy skin).Aug 8 2024, 1:19 PM

https://ru.wikipedia.org/wiki/Авами_лиг?useskin=monobook has the same issue but with the skin looking like this:

image.png (940×1 px, 332 KB)

So not Vector-related.

matmarex claimed this task.Aug 8 2024, 1:19 PM
matmarex subscribed.

I can have a look.

matmarex added a comment.Aug 8 2024, 1:23 PM

https://gerrit.wikimedia.org/r/c/mediawiki/extensions/FlaggedRevs/+/1057993/3/includes/frontend/FlaggablePageView.php#b353 I think this Html::closeElement( 'div' ); should not have been removed.

gerritbot added a comment.Aug 8 2024, 1:27 PM

Change #1060835 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/FlaggedRevs@master] Add missing close tags to #contentSub message

https://gerrit.wikimedia.org/r/1060835

gerritbot added a project: Patch-For-Review.Aug 8 2024, 1:27 PM
matmarex added a parent task: T366962: 1.43.0-wmf.17 deployment blockers.Aug 8 2024, 1:30 PM
gerritbot added a comment.Aug 8 2024, 1:47 PM

Change #1060839 had a related patch set uploaded (by Ladsgroup; author: Bartosz Dziewoński):

[mediawiki/extensions/FlaggedRevs@wmf/1.43.0-wmf.17] Add missing close tags to #contentSub message

https://gerrit.wikimedia.org/r/1060839

• jnuche subscribed.Aug 8 2024, 1:51 PM

Thanks @matmarex and @Ladsgroup for taking care of this.

gerritbot added a comment.Aug 8 2024, 1:58 PM

Change #1060839 merged by jenkins-bot:

[mediawiki/extensions/FlaggedRevs@wmf/1.43.0-wmf.17] Add missing close tags to #contentSub message

https://gerrit.wikimedia.org/r/1060839

Stashbot added a comment.Aug 8 2024, 1:59 PM

Mentioned in SAL (#wikimedia-operations) [2024-08-08T13:59:29Z] <ladsgroup@deploy1003> Started scap sync-world: Backport for [[gerrit:1060839|Add missing close tags to #contentSub message (T372054)]]

ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.17; 2024-08-06).Aug 8 2024, 2:00 PM
gerritbot added a comment.Aug 8 2024, 2:01 PM

Change #1060835 merged by jenkins-bot:

[mediawiki/extensions/FlaggedRevs@master] Add missing close tags to #contentSub message

https://gerrit.wikimedia.org/r/1060835

Stashbot added a comment.Aug 8 2024, 2:02 PM

Mentioned in SAL (#wikimedia-operations) [2024-08-08T14:02:56Z] <ladsgroup@deploy1003> ladsgroup: Backport for [[gerrit:1060839|Add missing close tags to #contentSub message (T372054)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Ladsgroup closed this task as Resolved.Aug 8 2024, 2:11 PM
Maintenance_bot removed a project: Patch-For-Review.Aug 8 2024, 2:30 PM
ReleaseTaggerBot edited projects, added MW-1.43-notes (1.43.0-wmf.18; 2024-08-13); removed MW-1.43-notes (1.43.0-wmf.17; 2024-08-06).Aug 8 2024, 3:00 PM
Tacsipacsi mentioned this in T371571: flaggedrevs_reviewform has too much margin-left in vector 2010.Aug 19 2024, 6:09 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits