Page MenuHomePhabricator
Create Task
Maniphest T367948

Display link to wikitext diff when reporting a successful patch addition
Closed, ResolvedPublicFeature
Actions

Description

Feature summary: Add a link to the diff on https://wikitech.wikimedia.org/wiki/Deployments when a patch has been added

Use case(s): When you successfully add a patch to https://wikitech.wikimedia.org/wiki/Deployments via the Schedule Deployment tool, the message letting you know that it was successful should include a link to the diff on that Wikitech page, so that you can easily verify that it was added correctly.

Benefits: Gives an easy link to verify that the change was added, and also lets you see how many/which other patches are already in the same deployment window.

Event Timeline

jhsoby created this task.Jun 19 2024, 8:34 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 19 2024, 8:34 AM
• bd808 renamed this task from Link diff to Display link to wikitext diff when reporting a successful patch addition.Jun 24 2024, 8:51 PM
kostajh awarded a token.Jun 27 2024, 6:12 PM
• bd808 moved this task from Backlog to Ready to Go on the Tool-schedule-deployment board.Jul 16 2024, 8:09 PM
• bd808 subscribed.

This will need some template string escaping work to implement. The current render templates for flash messages HTML escape the message body on output. This would need to be changed to either use the |safe filter or, maybe better actually, have the source message wrapped in a markupsafe.Markup object to allow HTML content to pass through.

• bd808 triaged this task as Medium priority.Jul 16 2024, 8:09 PM
• bd808 changed the task status from Open to In Progress.Jul 29 2024, 1:38 AM
• bd808 claimed this task.
• bd808 moved this task from Ready to Go to Doing on the Tool-schedule-deployment board.
Restricted Application added a project: User-bd808. · View Herald TranscriptJul 29 2024, 1:38 AM
CodeReviewBot added a project: Patch-For-Review.Jul 29 2024, 1:48 AM

bd808 opened https://gitlab.wikimedia.org/toolforge-repos/schedule-deployment/-/merge_requests/10

Link to diff after scheduling patch

CodeReviewBot added a comment.Jul 29 2024, 1:53 AM

bd808 merged https://gitlab.wikimedia.org/toolforge-repos/schedule-deployment/-/merge_requests/10

Link to diff after scheduling patch

Stashbot added a comment.Jul 29 2024, 1:56 AM

Mentioned in SAL (#wikimedia-cloud) [2024-07-29T01:56:48Z] <wmbot~bd808@tools-bastion-12> Built new image from 19588358 (T367948)

Stashbot added a comment.Jul 29 2024, 1:57 AM

Mentioned in SAL (#wikimedia-cloud) [2024-07-29T01:57:22Z] <wmbot~bd808@tools-bastion-12> Restart to pick up new container image (T367948)

• bd808 closed this task as Resolved.Jul 29 2024, 1:58 AM
Maintenance_bot removed a project: Patch-For-Review.Jul 29 2024, 2:30 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits