Inconsistent views for contents within <dl> tag between desktop and mobile view
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	Great_Brightstar
	Jun 10 2024, 5:12 PM

Description

Steps to replicate the issue (include links if applicable):

What happens?:

In <dl> tag, <dt> tag have no margin at left side on desktop view, but on mobile view, it has margin.

What should have happened instead?:

Contents within <dl> tag should have the same look for both desktop and mobile view

Software version (on Special:Version page; skip for WMF-hosted wikis like Wikipedia): 1.43.0-wmf.8 (f95d369)

Other information (browser name/version, screenshots, etc.): Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:126.0) Gecko/20100101 Firefox/126.0

QA Results - PROD

AC	Status	Details
1	✅	T367092#9978643

Details

	Subject	Repo	Branch	Lines +/-
	Definition list has no left margin, only definition items do	mediawiki/skins/MinervaNeue	master	+4 -9

Customize query in gerrit

Related Objects

Mentioned In: T369121: [Spike 4hrs] Why does color contrast tool give different results for desktop and mobile?
T368687: Verify 1.43.0-wmf.13 deployment
Mentioned Here: rSMIN003d9fea5be9: dd elements should have no margin
rMWf95d36963950: Merge "textSelection: Stop initializing default methods on each call"

Event Timeline

Great_Brightstar created this task.Jun 10 2024, 5:12 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 10 2024, 5:12 PM

Aklapper added a project: MinervaNeue.Jun 10 2024, 5:16 PM

rSMIN003d9fea5be9252974f1f17b62a4af9445ced098 is the immediate cause, though you will want to research further.

Izno unsubscribed.Jun 10 2024, 5:20 PM

The patch was merged for discussion tools so needs to be evaluated within the context of this project! Thanks for the bug report!

The problem is more clearly visible in various glossary articles, for example:

matmarex claimed this task.Jun 21 2024, 9:38 PM

Change #1048573 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/skins/MinervaNeue@master] Definition list has no left margin, only definition items do

https://gerrit.wikimedia.org/r/1048573

gerritbot added a project: Patch-For-Review.Jun 21 2024, 9:38 PM

Change #1048573 merged by jenkins-bot:

[mediawiki/skins/MinervaNeue@master] Definition list has no left margin, only definition items do

https://gerrit.wikimedia.org/r/1048573

ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.13; 2024-07-09).Jul 3 2024, 5:00 PM

@JScherer-WMF FYI change will be riding train next week. Move to sign off once you've taken a look.

Jdlrobson moved this task from Needs analysis to Design Review on the Web-Team-Backlog (FY2024-25 Q1 Sprint 1) board.Jul 3 2024, 5:10 PM

Jdlrobson triaged this task as High priority.Jul 3 2024, 6:02 PM

Jdlrobson lowered the priority of this task from High to Low.

@JScherer-WMF To verify

Maintenance_bot removed a project: Patch-For-Review.Jul 9 2024, 4:32 PM

GMikesell-WMF mentioned this in T368687: Verify 1.43.0-wmf.13 deployment.Jul 11 2024, 5:13 PM

Desktop and mobile are similar now with margins.

Test Result - PROD

Status: ✅ PASS
Environment: PROD
OS: macOS Sonoma 14.5
Browser: Chrome 126
Device: MBA
Emulated Device: NA

Test Artifact(s):

Test Steps

Desktop	Mobile

https://en.wikipedia.org/wiki/Glossary_of_cue_sports_terms#1–9
https://en.m.wikipedia.org/wiki/Glossary_of_cue_sports_terms#1–9

Desktop	Mobile

GMikesell-WMF added a project: Verified.Jul 12 2024, 10:48 PM

GMikesell-WMF updated the task description. (Show Details)

GMikesell-WMF updated the task description. (Show Details)Jul 12 2024, 11:13 PM

ovasileva closed this task as Resolved.Jul 15 2024, 5:20 PM

ovasileva mentioned this in T369121: [Spike 4hrs] Why does color contrast tool give different results for desktop and mobile?.Jul 15 2024, 5:25 PM

	F55543689: image.png
	Jun 21 2024, 9:31 PM

	F55543685: image.png
	Jun 21 2024, 9:31 PM

Inconsistent views for contents within <dl> tag between desktop and mobile viewClosed, ResolvedPublicBUG REPORTActions