Page MenuHomePhabricator
Create Task
Maniphest T365647

Ensure api-testing MediaWiki core tests pass when temp account feature flag is enabled
Closed, ResolvedPublic
Actions

Description

Acceptance criteria:

Status (22 May 2024):

P62931 api-testing failed tests
119:32:21 1) Page History
219:32:21 "before all" hook in "Page History":
319:32:21 AssertionError: User "127.0.0.1": Action "edit" returned error code "badtoken": Invalid CSRF token.!
419:32:21 at Client.action (node_modules/api-testing/lib/actionapi.js:123:11)
519:32:21 at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
619:32:21 at async Client.edit (node_modules/api-testing/lib/actionapi.js:322:18)
719:32:21 at async Context.<anonymous> (tests/api-testing/REST/PageHistory.js:60:16)
819:32:21
919:32:21 2) Testing default autopatrolling rights
1019:32:21 should confirm autopatrolling rights:
1119:32:21
1219:32:21 AssertionError: expected [ { type: 'edit', …(3) }, …(1) ] to have the same members as [ …(2) ]
1319:32:21 + expected - actual
1419:32:21
1519:32:21 [
1619:32:21 {
1719:32:21 - "temp": ""
1819:32:21 + "anon": ""
1919:32:21 "type": "edit"
2019:32:21 "unpatrolled": ""
2119:32:21 "user": "~2024-4"
2219:32:21 }
2319:32:21
2419:32:21 at Context.<anonymous> (tests/api-testing/action/Autopatrolling.js:27:10)
2519:32:21 at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
2619:32:21
2719:32:21 3) The edit action
2819:32:21 allows a page to be created and modified by an anonymous user:
2919:32:21
3019:32:21 AssertionError: expected '~2024-5' to equal '127.0.0.1'
3119:32:21 + expected - actual
3219:32:21
3319:32:21 -~2024-5
3419:32:21 +127.0.0.1
3519:32:21
3619:32:21 at testEditAndLog (tests/api-testing/action/Edit.js:25:10)
3719:32:21 at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
3819:32:21 at async Context.<anonymous> (tests/api-testing/action/Edit.js:54:3)
3919:32:21
4019:32:21 4) Page protection
4119:32:21 levels
4219:32:21 should NOT allow anonymous user to edit Protected page:
4319:32:21
4419:32:21 AssertionError: expected 'badtoken' to equal 'protectedpage'
4519:32:21 + expected - actual
4619:32:21
4719:32:21 -badtoken
4819:32:21 +protectedpage
4919:32:21
5019:32:21 at Context.<anonymous> (tests/api-testing/action/PageProtection.js:165:11)
5119:32:21 at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
5219:32:21
5319:32:21 5) Page protection
5419:32:21 levels
5519:32:21 should NOT allow anonymous user to edit Semi Protected page:
5619:32:21
5719:32:21 AssertionError: expected 'badtoken' to equal 'protectedpage'
5819:32:21 + expected - actual
5919:32:21
6019:32:21 -badtoken
6119:32:21 +protectedpage
6219:32:21
6319:32:21 at Context.<anonymous> (tests/api-testing/action/PageProtection.js:176:11)
6419:32:21 at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
6519:32:21
6619:32:21 6) Page protection
6719:32:21 levels
6819:32:21 should allow a restriction to be specified that allows users to edit it and only sysops to move a page:
6919:32:21
7019:32:21 AssertionError: expected 'badtoken' to equal 'protectedpage'
7119:32:21 + expected - actual
7219:32:21
7319:32:21 -badtoken
7419:32:21 +protectedpage
7519:32:21
7619:32:21 at Context.<anonymous> (tests/api-testing/action/PageProtection.js:206:11)
7719:32:21 at process.processTicksAndRejections (node:internal/process/task_queues:95:5)

The work here is a mix of:

  1. If using an anonymous user and anonymous token, only make one edit per test. That's because subsequent edits would be done as a temp user. (Alternatively, clear the cached token and re-request it.)
  2. If we are not explicitly testing anonymous editing behavior, consider just using a regular, named user account for the edits
  3. In some cases, business logic needs to be updated. For example, PageHistoryCountHandler should not include temp account contributions in the getAnonAccount method, to be consistent with other APIs - T365673: PageHistoryCountHandler should be able to show edit counts from temporary accounts.

Business logic changes (like T365673) should be tracked in subtasks. Patches that update core's api-testing tests can tag this task.

Details

SubjectRepoBranchLines +/-
api-testing/REST/PageHistory.js: update tests for temp accountmediawiki/coremaster+33 -10
api-testing/action/PageProtection.js: clear state for each testmediawiki/coremaster+3 -3
api-testing/action/Edit.js: Adjust username assertion for anonymousmediawiki/coremaster+9 -4
api-testing/action/Autopatrolling.js: adjust key prop for temp accountmediawiki/coremaster+19 -4
api-testing/REST/Update.js: Use named user for editsmediawiki/coremaster+15 -19
api-testing/REST/Page.js: Use authenticated user for editsmediawiki/coremaster+9 -10
api-testing/REST/Creation.js: Reset REST client before each test runmediawiki/coremaster+7 -7
Customize query in gerrit

Related Objects
Search...

Event Timeline

kostajh created this task.May 22 2024, 8:01 PM
kostajh updated the task description. (Show Details)May 22 2024, 8:21 PM
kostajh updated the task description. (Show Details)May 22 2024, 8:24 PM
kostajh updated the task description. (Show Details)
gerritbot added a comment.May 23 2024, 8:09 AM

Change #1035317 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[mediawiki/core@master] api-testing: Reset REST client before each test run

https://gerrit.wikimedia.org/r/1035317

gerritbot added a project: Patch-For-Review.May 23 2024, 8:09 AM
kostajh updated the task description. (Show Details)May 23 2024, 8:13 AM
kostajh updated the task description. (Show Details)May 23 2024, 8:15 AM
kostajh added a subtask: T365673: PageHistoryCountHandler should be able to show edit counts from temporary accounts.
kostajh updated the task description. (Show Details)
kostajh renamed this task from Ensure api-testing tests pass when temp account feature flag is enabled to Ensure api-testing MediaWiki core tests pass when temp account feature flag is enabled.May 23 2024, 8:29 AM
kostajh mentioned this in T303255: Core apitests job should run extension/skin api tests as well.
kostajh added a subtask: T303255: Core apitests job should run extension/skin api tests as well.
kostajh removed a subtask: T303255: Core apitests job should run extension/skin api tests as well.
Tchanders moved this task from Inbox to Release train CI and infrastructure on the Temporary accounts board.Jun 4 2024, 12:56 PM
Tchanders edited projects, added Temporary accounts (Release train CI and infrastructure); removed Temporary accounts.
kostajh mentioned this in T365676: [REPO][SW] Ensure api-testing MediaWiki extension tests pass when temp account feature flag is enabled.Jun 27 2024, 5:26 PM
Tchanders edited projects, added Temporary accounts (Blockers to testwiki deployment); removed Temporary accounts (Release train CI and infrastructure).Jul 3 2024, 2:57 PM
kostajh added a comment.Jul 9 2024, 1:49 PM

While we work on adapting the tests to work with temp accounts, two things we could consider:

  • create a hack to disable temp accounts via a LocalSettings override, so api-testing tests always run with temp accounts being disabled
  • selectively skip failing api-testing tests if temp accounts are enabled (by querying siteinfo)
gerritbot added a comment.Jul 10 2024, 10:28 AM

Change #1053275 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[mediawiki/core@master] api-testing/REST/Page.js: Use authenticated user for edits

https://gerrit.wikimedia.org/r/1053275

gerritbot added a comment.Jul 10 2024, 11:15 AM

Change #1053284 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[mediawiki/core@master] api-testing/REST/Update.js: Use named user for edits

https://gerrit.wikimedia.org/r/1053284

gerritbot added a comment.Jul 10 2024, 1:23 PM

Change #1035317 merged by jenkins-bot:

[mediawiki/core@master] api-testing/REST/Creation.js: Reset REST client before each test run

https://gerrit.wikimedia.org/r/1035317

ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.14; 2024-07-16).Jul 10 2024, 2:00 PM
Mimurawil changed the task status from Open to In Progress.Jul 10 2024, 3:32 PM
Mimurawil claimed this task.
gerritbot added a comment.Jul 10 2024, 5:50 PM

Change #1053362 had a related patch set uploaded (by Mimurawil; author: Mimurawil):

[mediawiki/core@master] api-testing/action/Edit.js: Adjust username assertion for anonymous

https://gerrit.wikimedia.org/r/1053362

gerritbot added a comment.Jul 10 2024, 6:38 PM

Change #1053368 had a related patch set uploaded (by Mimurawil; author: Mimurawil):

[mediawiki/core@master] api-testing/action/Autopatrolling.js: adjust key prop for temp account

https://gerrit.wikimedia.org/r/1053368

gerritbot added a comment.Jul 10 2024, 8:15 PM

Change #1053380 had a related patch set uploaded (by Mimurawil; author: Mimurawil):

[mediawiki/core@master] api-testing/REST/PageHistory.js: update tests for temp account

https://gerrit.wikimedia.org/r/1053380

gerritbot added a comment.Jul 10 2024, 9:00 PM

Change #1053382 had a related patch set uploaded (by Mimurawil; author: Mimurawil):

[mediawiki/core@master] api-testing/action/PageProtection.js: clear state for each test

https://gerrit.wikimedia.org/r/1053382

gerritbot added a comment.Jul 11 2024, 9:06 AM

Change #1053275 merged by jenkins-bot:

[mediawiki/core@master] api-testing/REST/Page.js: Use authenticated user for edits

https://gerrit.wikimedia.org/r/1053275

gerritbot added a comment.Jul 11 2024, 9:54 AM

Change #1053284 merged by jenkins-bot:

[mediawiki/core@master] api-testing/REST/Update.js: Use named user for edits

https://gerrit.wikimedia.org/r/1053284

gerritbot added a comment.Jul 11 2024, 9:54 AM

Change #1053362 merged by jenkins-bot:

[mediawiki/core@master] api-testing/action/Edit.js: Adjust username assertion for anonymous

https://gerrit.wikimedia.org/r/1053362

gerritbot added a comment.Jul 11 2024, 9:55 AM

Change #1053368 merged by jenkins-bot:

[mediawiki/core@master] api-testing/action/Autopatrolling.js: adjust key prop for temp account

https://gerrit.wikimedia.org/r/1053368

gerritbot added a comment.Jul 11 2024, 9:55 AM

Change #1053380 merged by jenkins-bot:

[mediawiki/core@master] api-testing/REST/PageHistory.js: update tests for temp account

https://gerrit.wikimedia.org/r/1053380

gerritbot added a comment.Jul 11 2024, 9:55 AM

Change #1053382 merged by jenkins-bot:

[mediawiki/core@master] api-testing/action/PageProtection.js: clear state for each test

https://gerrit.wikimedia.org/r/1053382

Maintenance_bot removed a project: Patch-For-Review.Jul 11 2024, 10:30 AM
Tchanders closed subtask T365673: PageHistoryCountHandler should be able to show edit counts from temporary accounts as Resolved.Jul 19 2024, 9:24 AM
Tchanders added a comment.Jul 19 2024, 9:31 AM

Can this be closed, now that https://gerrit.wikimedia.org/r/c/mediawiki/core/+/980947 was merged? (It's not the patch in the task description.)

Dreamy_Jazz closed this task as Resolved.Jul 19 2024, 12:55 PM
Dreamy_Jazz updated the task description. (Show Details)
Dreamy_Jazz updated the task description. (Show Details)

Going to mark this as resolved, given that both patches (the one linked and the one that was merged) are passing their tests.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits