Transaction fee (PTF) on Native form does not update with Amount
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	HNordeenWMF
	May 17 2024, 11:28 PM

Description

Steps to replicate the issue (include links if applicable):

Settings > Donate
Donate with Google Pay
Choose first amount ($3), then choose last suggested amount ($100)

What happens?:

Transaction fee remains the same at $0.35

What should have happened instead?:

Transaction fee should scale up with amount, matching behavior of donate.wikimedia.org

(https://drive.google.com/file/d/1hAqiOGtYRxDoQ8Y2E5GGSg2MYVIxn4Uf/view?usp=sharing)

Reference

The fee should be 4% of the amount, or the relevant fee minimum, whichever is higher. The default fee minimum is 0.35
Function: https://meta.wikimedia.org/wiki/MediaWiki:FundraisingBanners/CoreJS-2018.js#L-461

Event Timeline

HNordeenWMF created this task.May 17 2024, 11:28 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 17 2024, 11:28 PM

What is the formula used for the web form?

I just added the formula from the web form into task the description.

Dbrant claimed this task.May 23 2024, 5:18 PM

Dbrant triaged this task as Medium priority.

Dbrant moved this task from Needs Triage to Android Release - FY2023-24 on the Wikipedia-Android-App-Backlog board.

Dbrant edited projects, added Wikipedia-Android-App-Backlog (Android Release - FY2023-24); removed Wikipedia-Android-App-Backlog.

dbrant opened https://github.com/wikimedia/apps-android-wikipedia/pull/4694

Dbrant moved this task from Epics in Progress to Code Review on the Wikipedia-Android-App-Backlog (Android Release - FY2023-24) board.May 23 2024, 5:18 PM

@HNordeenWMF This is easily done, but it actually conflicts with a minor bit of UX that we have currently, namely: when you select the checkbox to "add the transaction fee", we actually update the text field with the total amount to include the fee. But now, if the transaction fee is dependent on the amount, updating the text to include the fee becomes impossible.
Would it be acceptable to no longer update the amount that's in the text field to include the fee? (This would actually also bring it more in line with behavior on Web.)

It would be preferred to no longer update the amount that's in the text field to include the fee. That is how it happens in a web banner as well, except they have a confirmation button that shows your total with one time / monthly so there's that extra confirmation.

But could you wait to release this task? I am checking in with fundraising on the priority. Then I'd like to ensure the change happens at a similar time for iOS and Android.

Dbrant moved this task from Code Review to Blocked/Waiting on the Wikipedia-Android-App-Backlog (Android Release - FY2023-24) board.May 30 2024, 2:04 PM