Page MenuHomePhabricator

Remove meaningless "Cite error: …" prefix in favor of independent error messages
Open, Needs TriagePublic

Description

As a small, iterative step towards T321217: Get rid of Cite formatting i18n messages that are not actually localized we suggest to empty (but not delete) the two messages cite_error and cite_warning.

  • cite_error currently says "Cite error: $1" and should be changed to "$1" or "-".
  • cite_warning currently says "Cite warning: $1" and should be changed the same way.

Reasoning:

  • The problems with these two messages have been discussed in T30843: Cite error uses lego messages breaking localisation and customisation, should be deprecated. The common prefix doesn't help much, but makes localizing the individual error messages harder. Most of the errors already talk about the context they apply to, some don't, resulting in inconsistent experience. Instead, every messages should be self-contained and explain what it is about.
  • Just deleting the messages is not an option as long as the communities use them heavily for all kinds of customizations (tracking categories, custom templates).
  • …?

To do:

Event Timeline

Change 995055 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/Cite@master] Make it possible to disable the "cite_error" wrapper message

https://gerrit.wikimedia.org/r/995055

Change #995055 merged by jenkins-bot:

[mediawiki/extensions/Cite@master] Make it possible to disable the "cite_error" wrapper message

https://gerrit.wikimedia.org/r/995055

Thiemo has also found a special behavior which will be challenging to reimplement: simply adding a tracking category to all pages where a Cite error occurs might not be fully equivalent to the logic on some wikis, which conditionally adds special tracking categories depending on the type of error or in specific namespaces. In other words, some errors are being ignored.