Page MenuHomePhabricator

Translation progress stats are not cleared when deleting a translation page
Closed, ResolvedPublic4 Estimated Story PointsBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

  • Create a translatable page
  • Translate any part of that page into any language
  • Delete the translation page for that language
  • Visit MessageGroupStats for that page

What happens?:

  • Statistics in that language are not purged

What should have happened instead?:

  • Statistics are purged

Software version (skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

This seems to be because Hooks::$jobQueueRunning is true while running the deletions. This logic exists to avoid potential slowdown of purging the stats for each of the translation unit page deletion separately. However there is no code in DeleteTranslatableBundleJob::run to clear/recalculate the statistics.

Event Timeline

Change 982787 had a related patch set uploaded (by Nikerabbit; author: Nikerabbit):

[mediawiki/extensions/Translate@master] Purge statistics when deleting a translation page

https://gerrit.wikimedia.org/r/982787

Nikerabbit changed the task status from Open to In Progress.Jan 8 2024, 7:55 AM

Change 982787 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] Purge statistics when deleting a translation page

https://gerrit.wikimedia.org/r/982787