Page MenuHomePhabricator

"Recent changes" in the advanced Mobile Frontend menu may show unnecessarily escaped characters
Closed, ResolvedPublicBUG REPORT

Description

NOTE: Please QA this directly in production and add verified tag.

Steps to replicate the issue (include links if applicable):

What happens?:

The "recent changes" link title appears as "A'wanajaanüka yaawala".

Screenshot_20231204_000908_Firefox.jpg (2×1 px, 246 KB)

What should have happened instead?:

The recent changes link is supposed to appear as "A'wanajaanüka yaawala", with an apostrophe and not with an HTML entity.

Other information (browser name/version, screenshots, etc.):

As far as I can see, the message is recentchanges, that is, the same one that is used in the core and desktop. It's a bit surprising because the usual practice in MediaWiki is to make copies of messages and not to reuse them, even if they are expected to be the same. By itself, the reuse is probably not the cause for this issue (or is it?), but consider fixing it along the way.

QA Results - PROD

ACStatusDetails
1T352626#10012099

Event Timeline

Jdlrobson subscribed.

Encoding issue. Hopefully easy to fix.

Jdlrobson triaged this task as Medium priority.Dec 4 2023, 6:09 PM

Change #1052967 had a related patch set uploaded (by GergesShamon; author: GergesShamon):

[mediawiki/skins/MinervaNeue@master] use text() instead of escaped() for msg recentchanges

https://gerrit.wikimedia.org/r/1052967

Change #1052971 had a related patch set uploaded (by GergesShamon; author: GergesShamon):

[mediawiki/skins/MinervaNeue@wmf/1.43.0-wmf.12] use text() instead of escaped() for msg recentchanges

https://gerrit.wikimedia.org/r/1052971

Change #1052967 abandoned by GergesShamon:

[mediawiki/skins/MinervaNeue@master] use text() instead of escaped() for msg recentchanges

Reason:

https://gerrit.wikimedia.org/r/1052967

Change #1052967 restored by GergesShamon:

[mediawiki/skins/MinervaNeue@master] use text() instead of escaped() for msg recentchanges

https://gerrit.wikimedia.org/r/1052967

Change #1052967 merged by jenkins-bot:

[mediawiki/skins/MinervaNeue@master] use text() instead of escaped() for msg recentchanges

https://gerrit.wikimedia.org/r/1052967

Change #1052971 merged by jenkins-bot:

[mediawiki/skins/MinervaNeue@wmf/1.43.0-wmf.12] use text() instead of escaped() for msg recentchanges

https://gerrit.wikimedia.org/r/1052971

Mentioned in SAL (#wikimedia-operations) [2024-07-09T20:56:46Z] <urbanecm@deploy1002> Started scap sync-world: Backport for [[gerrit:1052971|use text() instead of escaped() for msg recentchanges (T352626)]]

Mentioned in SAL (#wikimedia-operations) [2024-07-09T21:00:51Z] <urbanecm@deploy1002> gergesshamon, urbanecm: Backport for [[gerrit:1052971|use text() instead of escaped() for msg recentchanges (T352626)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Jdlrobson added a subscriber: Gerges.

Thanks to @Gerges we have a fix for this finally <3. Moving into sprint for some QA.

Jdlrobson lowered the priority of this task from Medium to Low.
Jdlrobson updated the task description. (Show Details)

Mentioned in SAL (#wikimedia-operations) [2024-07-09T21:18:37Z] <urbanecm@deploy1002> Finished scap: Backport for [[gerrit:1052971|use text() instead of escaped() for msg recentchanges (T352626)]] (duration: 21m 50s)

Done bug solved

Hi @Gerges we are just going to run this past our QA engineer to confirm the fix and check for regressions. We will resolve it once that's done! Thanks again for working on this.

Test Result - PROD

Status: ✅ PASS
Environment: PROD
OS: macOS Sonoma 14.5
Browser: Chrome 126
Device: MBA
Emulated Device: NA

Test Artifact(s):

Test Steps
  1. Go to https://guc.m.wikipedia.org . (Wayuu Wikipedia, mobile web version.)
  2. Log in.
  3. Enable advanced mm mobile mode.
  4. Go back to the main page, https://guc.m.wikipedia.org .
  5. Tap the hamburger at the top left.

2024-07-24_10-40-41.png (1×2 px, 364 KB)

Jdlrobson claimed this task.
Jdlrobson added a project: Verified.