Page MenuHomePhabricator
Create Task
Maniphest T339353

SearchPreview: Code improvement - Create a DOM modules to centralise all DOM manipulations
Closed, ResolvedPublic
Actions

Description

As a developer I would like all the DOM manipulations to be centralised in one single Pinia Module, so that I can easily understand all actions that modify the DOM.

AC:

  • Move all DOM within the new Pinia Module
  • Unit Test the new Module

Details

SubjectRepoBranchLines +/-
SearchPreview: Code improvement - Create a DOM modules to centralise all DOM manipulationsmediawiki/extensions/SearchVuemaster+265 -139
Customize query in gerrit

Related Objects

Event Timeline

SimoneThisDot created this task.Jun 16 2023, 11:38 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 16 2023, 11:39 AM
SimoneThisDot moved this task from Ready for Development to Doing on the Structured-Data-Backlog (Current Work) board.Jun 16 2023, 11:39 AM
gerritbot added a comment.Jun 20 2023, 8:12 AM

Change 931546 had a related patch set uploaded (by Simone Cuomo; author: Simone Cuomo):

[mediawiki/extensions/SearchVue@master] earchPreview: Code improvement - Create a DOM modules to centralise all DOM manipulations

https://gerrit.wikimedia.org/r/931546

gerritbot added a project: Patch-For-Review.Jun 20 2023, 8:12 AM
SimoneThisDot moved this task from Doing to Code Review on the Structured-Data-Backlog (Current Work) board.Jun 22 2023, 8:06 AM
gerritbot added a comment.Jun 23 2023, 12:19 PM

Change 931546 merged by jenkins-bot:

[mediawiki/extensions/SearchVue@master] SearchPreview: Code improvement - Create a DOM modules to centralise all DOM manipulations

https://gerrit.wikimedia.org/r/931546

SimoneThisDot mentioned this in rESVUf1d554d5af3d: SearchPreview: Code improvement - Create a DOM modules to centralise all DOM….Jun 23 2023, 12:20 PM
Maintenance_bot removed a project: Patch-For-Review.Jun 23 2023, 12:30 PM
ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.15; 2023-06-27).Jun 23 2023, 1:00 PM
matthiasmullie moved this task from Code Review to Needs QA on the Structured-Data-Backlog (Current Work) board.Jun 24 2023, 7:47 PM
Etonkovidova moved this task from Needs QA to Verify on Production on the Structured-Data-Backlog (Current Work) board.Jun 27 2023, 11:10 PM
Etonkovidova closed this task as Resolved.Jun 29 2023, 7:51 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits